Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System properties still reference forge instead of neoforge #24

Open
pupnewfster opened this issue Dec 7, 2023 · 4 comments
Open

System properties still reference forge instead of neoforge #24

pupnewfster opened this issue Dec 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@pupnewfster
Copy link
Member

forge.enabledGameTestNamespaces is still used instead neoforge.enabledGameTestNamespaces
@marchermans
Copy link
Contributor

Wait is this changed in nf itself?

@pupnewfster
Copy link
Member Author

Yes, neoforge checks against the neoforge prefixed one

@sciwhiz12 sciwhiz12 added the bug Something isn't working label Dec 23, 2023
@sciwhiz12
Copy link
Member

Note that we can only correct forge.enabledGameTestNamespaces currently -- forge.logging.markers doesn't seem to exist based on my current searches (though I know it did exist), and FancyModLoader's log4j2.xml still references the forge. suffix for forge.logging.console.level (and other similar logging-control system properties).

@pupnewfster
Copy link
Member Author

I believe that is correct, and is why I only listed one of those in the issue description.

@pupnewfster pupnewfster mentioned this issue Feb 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pupnewfster @marchermans @sciwhiz12