Ingredient parsing may swallow parse errors

[Shadows-of-Fire]

I was porting something containing the following Ingredient:

{
    "type": "forge:nbt",
    "item": "minecraft:potion",
    "nbt": "{\"Potion\": \"minecraft:night_vision\"}"
}

Since the ingredient type is now neoforged:nbt, I would expect this to error. However, this actually results in a successful deserialization with an ingredient containing just the minecraft:potion item.

[Technici4n]

That's a side-effect of using Either codecs. We probably want a way to skip the second codec if some key exists in the codec.

[KnightMiner]

Didn't we discuss this issue on Discord before? The solution recommend was instead of using an either codec, to just have the type field default to the ID of the vanilla serializer in the forge registry.

[marchermans]

Yes this was a direct concequence of the requirement that if you used the vanilla ingredient it should not have a "type" field.

If somebody knows a better codec setup to do this, I would be open to figure this out.

[FiniteReality]

If somebody knows a better codec setup to do this, I would be open to figure this out.

My thought would be a custom MapCodec based on KeyDispatchCodec which replaces the typeKey/keyCodec fields with a MapCodec which is built with optionalFieldOf

[Shadows-of-Fire]

I have this codec which is a dispatch codec with the ability to set a default type