Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more protections to SavedData for data corruption #775

Open
raoulvdberge opened this issue Apr 3, 2024 · 2 comments · May be fixed by #1001
Open

Add more protections to SavedData for data corruption #775

raoulvdberge opened this issue Apr 3, 2024 · 2 comments · May be fixed by #1001
Labels
enhancement New (or improvement to existing) feature or request

Comments

@raoulvdberge
Copy link

raoulvdberge commented Apr 3, 2024 •
edited

Currently, SavedData tends to lose persisted data in the event of a crash, power loss, etc.
@raoulvdberge raoulvdberge added the enhancement New (or improvement to existing) feature or request label Apr 3, 2024
@PlatinPython
Copy link
Contributor

Looking at the code, I don't see a reason why that should be the case, unless you didn't call setDirty in the constructor and/or whenever the data changes.
That being said, I can't actually test atm

@pupnewfster
Copy link
Member

Because the way it is handled the operating system fails to save the complete file especially when it is on the larger side.

@FiniteReality FiniteReality linked a pull request May 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to write saved data in a resilient manner FiniteReality/NeoForge
3 participants
@pupnewfster @raoulvdberge @PlatinPython