rare random Crafting Issue

[MSandro]

Minecraft Version: 1.20.4
NeoForge Version: 20.4.227

I'm really not sure if it's a problem directly with NeoForge. I've already reported the bug to a few mods.
In rare cases something seems to go wrong when loading recipes. I can rarely reproduce it.
I've spent many hours over the last few days trying to get to the bottom of the problem, but to no avail, I can't pinpoint an exact mod that might be to blame. The more mods are loaded, the more often it occurs.

Steps to Reproduce:

1. Join a world
2. put something in the crafting grid
3. sometimes you will get a random item as output

Description of issue:

[MSandro]

All of these issues are related to this:
mekanism/Mekanism#8056
TeamTwilight/twilightforest#2022
AztechMC/Modern-Industrialization#694
Glitchfiend/ToughAsNails#843

[shartte]

There was this Mojang bug I reported ages ago that was fixed a while back: https://bugs.mojang.com/browse/MC-244550

Did this get revived somehow?

[Technici4n]

It's probably due to our isEmpty ingredient patch + some bad luck?

[MSandro]

I have tried a mod which should be able to fix tag related issues:
https://www.curseforge.com/minecraft/mc-mods/lmft
but it did not work.

Now I've noticed that some items don't have tags when the issue occurs:

Here's what it looks like if the recipes are okay:

[MSandro]

I've noticed the same issue in this Modpack: https://www.curseforge.com/minecraft/modpacks/new-game-neoforge-version

But there is no tech mod like Mekanism or Modern Industrialization.
It is more like a large Vanilla+ Modpack.

The only mod that is also in my modpacks is Twilight Forest.

[Shadows-of-Fire]

Will be worth tracking the status of this after #793 to see if it still occurs, since it is obviously from some transient issue within the ingredient code.