Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eye of Ender items behave differently than vanilla. #796

Open
Chuzume opened this issue Apr 11, 2024 · 5 comments
Open

Eye of Ender items behave differently than vanilla. #796

Chuzume opened this issue Apr 11, 2024 · 5 comments
Labels
1.20.5 Targeted at Minecraft 1.20.5 vanilla bug A bug or error in the base Minecraft game wontfix This will not be worked on

Comments

@Chuzume
Copy link

Chuzume commented Apr 11, 2024

Minecraft Version: 1.20.4

NeoForge Version: 20.4.227

Description of issue:
In vanilla Minecraft, using the Eye of Ender in a world without stronghold slows down the player and triggering the Advancement "using_item" without consuming the item, but in NeoForge this Advancement cannot be triggered.

There are a few data packs that use the Eye of Ender trigger, but these will no longer work in NeoForge.
Also, this has been confirmed since Forge.

In vanilla

Vanilla.mp4

In Neo Forge

NeoForge.mp4
@Chuzume Chuzume added the triage Needs triaging and confirmation label Apr 11, 2024
@Shadows-of-Fire
Copy link
Contributor

Shadows-of-Fire commented Apr 15, 2024

How do you generate a world without a stronghold?
Resolved via datapack

@Shadows-of-Fire Shadows-of-Fire added bug A bug or error 1.20.5 Targeted at Minecraft 1.20.5 and removed triage Needs triaging and confirmation labels Apr 15, 2024
@Shadows-of-Fire
Copy link
Contributor

Shadows-of-Fire commented Apr 15, 2024

This is caused by a bugfix that forge has in place for https://bugs.mojang.com/browse/MC-107185

Our policy for vanilla bugfixes is to keep them in place unless major detrimental issues arise (i.e. MinecraftForge/MinecraftForge#9309); as such, we will keep this fix, though the patch for it (below) needs to be updated to explicitly reflect the bug that it is fixing (as it currently does not).

- if (--this.useItemRemaining == 0 && !this.level().isClientSide && !p_147201_.useOnRelease()) {
+ if (--this.useItemRemaining <= 0 && !this.level().isClientSide && !p_147201_.useOnRelease()) {

Leaving this issue open for the time being as a reminder to add the bug reference.

@Shadows-of-Fire Shadows-of-Fire added wontfix This will not be worked on vanilla bug A bug or error in the base Minecraft game and removed bug A bug or error labels Apr 15, 2024
@tmvkrpxl0
Copy link

tmvkrpxl0 commented Apr 15, 2024

How do you generate a world without a stronghold? Resolved via datapack

Btw flat world would've worked as well

@TelepathicGrunt
Copy link
Sponsor Contributor

@Shadows-of-Fire what about the advancement part of the issue?

triggering the Advancement "using_item" without consuming the item, but in NeoForge this Advancement cannot be triggered.

If using the item doesn't trigger the advancement like vanilla does, then the patch will need a slight adjustment to fire the use advancement without slowing the player down.

@Shadows-of-Fire
Copy link
Contributor

There's no way to keep the patch and maintain the behavior that triggers the particular advancement - the fact that it triggers at all is a bug (as indicated by Mojang), which means this behavior could stop functioning in any MC release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.5 Targeted at Minecraft 1.20.5 vanilla bug A bug or error in the base Minecraft game wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants