TagsProvider$TagAppender
constructor includes an additional and essentially unused mod id argument, making it impossible to extend the class in the common part of multi-loader projects
#831
Labels
1.20.5
Targeted at Minecraft 1.20.5
cleanup
Change that isn't an enhancement or a bug fix
help wanted
Extra attention is needed
triage
Needs triaging and confirmation
The vanilla constructor for
TagsProvider$TagAppender
only taking a singleTagBuilder
is missing, only one requiring an additional mod id in form of aString
exists. This makes it impossible to extendTagsProvider$TagAppender
(e.g. for adding more convenient overloads) in the common part of a multi-loader project.The added mod id argument is passed along a couple of times, but never actually ends up being used for anything. According to the Javadoc for the methods in
ITagBuilderExtension
where the argument eventually ends up being ignored, this was supposed to be used for logging purposes to indicate a source mod (which never happens).Also both the field and corresponding getter being named mod id is misleading, since e.g. for vanilla data providers not
minecraft
, butvanilla
is passed in.Would be great if the additional parameter could either be removed to restore the vanilla constructor, or if at least the vanilla constructor could be added back as an overload passing on an empty string.
The text was updated successfully, but these errors were encountered: