Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagsProvider$TagAppender constructor includes an additional and essentially unused mod id argument, making it impossible to extend the class in the common part of multi-loader projects #831

Open
Fuzss opened this issue Apr 21, 2024 · 0 comments
Labels
1.20.5 Targeted at Minecraft 1.20.5 cleanup Change that isn't an enhancement or a bug fix help wanted Extra attention is needed triage Needs triaging and confirmation

Comments

@Fuzss
Copy link

Fuzss commented Apr 21, 2024

The vanilla constructor for TagsProvider$TagAppender only taking a single TagBuilder is missing, only one requiring an additional mod id in form of a String exists. This makes it impossible to extend TagsProvider$TagAppender (e.g. for adding more convenient overloads) in the common part of a multi-loader project.

The added mod id argument is passed along a couple of times, but never actually ends up being used for anything. According to the Javadoc for the methods in ITagBuilderExtension where the argument eventually ends up being ignored, this was supposed to be used for logging purposes to indicate a source mod (which never happens).
Also both the field and corresponding getter being named mod id is misleading, since e.g. for vanilla data providers not minecraft, but vanilla is passed in.

Would be great if the additional parameter could either be removed to restore the vanilla constructor, or if at least the vanilla constructor could be added back as an overload passing on an empty string.

@Fuzss Fuzss added the triage Needs triaging and confirmation label Apr 21, 2024
@sciwhiz12 sciwhiz12 added cleanup Change that isn't an enhancement or a bug fix 1.20.5 Targeted at Minecraft 1.20.5 labels Apr 27, 2024
@Matyrobbrt Matyrobbrt added the help wanted Extra attention is needed label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.5 Targeted at Minecraft 1.20.5 cleanup Change that isn't an enhancement or a bug fix help wanted Extra attention is needed triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

3 participants