Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LivingEvent.LivingJumpEvent Bugs #843

Closed
ZestyBlaze opened this issue Apr 24, 2024 · 1 comment · Fixed by #966
Closed

LivingEvent.LivingJumpEvent Bugs #843

ZestyBlaze opened this issue Apr 24, 2024 · 1 comment · Fixed by #966
Assignees
Labels
1.20.5 Targeted at Minecraft 1.20.5 bug A bug or error triage Needs triaging and confirmation

Comments

@ZestyBlaze
Copy link

Minecraft Version: All versions of MC covered by Neo

NeoForge Version: All

Logs: N/A

Steps to Reproduce:

  1. Create an event of LivingEvent.LivingJumpEvent that gives glowing or hurts an entity when they jump or anything that lets you see when it fires
  2. Spawn in a Slime, Magma Cube, and a Tamed Horse
  3. Watch as the Magma Cube gets affected by the event, the Slime won't be however. When a rider jumps on a horse, it doesn't get affected by the event either

Description of issue:
So when digging through the events, I had a look at LivingEvent.LivingJumpEvent and noticed that it's not patched into Slime's despite being patched into Magma Cube's jumps, despite these mobs both being jumping mobs. Furthermore, despite AbstractHorse being patched, the event doesn't seem to fire for Horses when the rider jumps (As well the description for the event points to the wrong method in AbstractHorse as well). This means it probably also extends to Donkey's and Mules too since they both also extend AbstractHorse

@ZestyBlaze ZestyBlaze added the triage Needs triaging and confirmation label Apr 24, 2024
@sciwhiz12 sciwhiz12 added bug A bug or error 1.20.5 Targeted at Minecraft 1.20.5 labels Apr 27, 2024
@TelepathicGrunt
Copy link
Sponsor Contributor

TelepathicGrunt commented May 16, 2024

Horse does indeed trigger the event. Tested it right now. The executeRidersJump method in AbstractHorse is fired in tickRidden when the horse jumps. Goes for mules and all others. Only Camel overrides executeRidersJump and thus, won't fire the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.5 Targeted at Minecraft 1.20.5 bug A bug or error triage Needs triaging and confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants