All worlds have experimental settings with NeoForge

[Lolothepro]

NeoForge Version: 20.5.0-beta

Steps to Reproduce:

1. Try to generate a new world without any experimental settings
2. The experimental settings message is displayed.

Description of issue:
All worlds have experimental settings with NeoForge

2024-04-24.16-44-08.mp4

[lukebemish]

This will be fixed by adding a KnownPack for mod resource packs, which is doable (though the vanilla code path is a bit funky -- it might need a bit more than this) -- I plan to implement it once #735 is merged, as that PR sets up the infrastructure needed for hidden packs with KnownPacks to behave sensibly.

[lukebemish]

Should be fixed -- at least in many cases -- by #901.

[sciwhiz12]

"In many cases"? What edge cases aren't covered by that PR?

[lukebemish]

• Mod added dimensions, which are always experimental it seems
• Stuff added by packs in AddPackFindersEvent that do not add KnownPacks
• IDK, whatever other cases I've missed -- that lifecycle is collected from like 50 different places

But nothing in neoforge itself, just stuff mods would add.

[sciwhiz12]

Ah, but the PR will at least fix this issue, which occurs with NeoForge-only.

[lukebemish]

Yes, and will fix most mod-caused equivalents -- any caused by the more "normal" non-dynamic datapack registries, from mod built-in datapacks.