Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add DevLogin support to client run configs #100

Closed
ApexModder opened this issue Jan 9, 2024 · 1 comment · Fixed by #192
Closed

[Feature Request] Add DevLogin support to client run configs #100

ApexModder opened this issue Jan 9, 2024 · 1 comment · Fixed by #192

Comments

@ApexModder
Copy link

ApexModder commented Jan 9, 2024

DevLogin allows users to authenticate their clients using Mojangs services at startup.

Adding DevLogin to any NeoForge mod involves the following steps currently.

While this is a simple setup, I think it would make sense for NeoGradle, and potentially other loaders too, to include DevLogin as a feature for their client run configs.
Of course this would have to be a opt-in feature, having it enabled by default wouldn't make much sense IMO.

I am thinking of adding a super simple boolean flag (authed true) to client configs, which when enabled

  • sets the main class to net.covers1624.devlogin.DevLogin
  • sets the program arg --launch_target to cpw.mods.bootstraplauncher.BootstrapLauncher
  • and tells DevLogin to use the default auth profile via --launch_profile default
    There should also be an optional property users can specify to set the profile that DevLogin will use. This will allow users to authenticate their clients with multiple accounts.
    Maybe something like authProfile <profile> (if set also sets authed true)
@ApexModder ApexModder changed the title Add DevLogin support to client run configs [Feature Request] Add DevLogin support to client run configs Jan 9, 2024
@Gaming32
Copy link

Gaming32 commented Jan 9, 2024

I prefer DevAuth personally. It doesn't require fiddling with the main class. Alternatively, NeoGradle could handle login itself; it's not that hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants