Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vineflower Error-Handling #45

Open
shartte opened this issue Nov 11, 2023 · 0 comments
Open

Improve Vineflower Error-Handling #45

shartte opened this issue Nov 11, 2023 · 0 comments

Comments

@shartte
Copy link
Contributor

shartte commented Nov 11, 2023

If Vineflower runs out of memory, it'll skip a method and continue and ultimately return exit code 0, leading to an output.jar for which patching will fail (due to broken methods):

WARN:           Method <clinit> ()V in class net/minecraft/world/level/block/Blocks couldn't be decompiled.
java.lang.OutOfMemoryError: Java heap space
[...]
INFO:  ... done

We probably need to make our handling of Vineflower more robust. This is just a marker issue to remember to do that.
Switching to the Vineflower API may improve our ability to handle this, but has other significant cost associated with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant