-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues migrating multi-project build with Game Library to NG 7+ #64
Comments
Please see #52 instead for how to correctly replace game libraries. |
I have, you can see I'm using that system in my 1.20.2 branch |
You shouldn't have to touch the |
I can maybe give your project a look in a few hours, |
Thanks I appreciate it, I've updated the original post with a few relevant GitHub issues on ForgeGradle as well. Just to hopefully give context as to the setup I've been running with since then. |
If there's any additional info needed feel free to reach out. |
I did some research a bit internally:
|
I suppose just leave the issue for the time being until that fix is in place?
Gotcha, only concern here is that my other project isn't a mod, it's a library that depends on the game sources. I'm hoping that won't be an issue though? |
It's fine yes. "Mod sources" here means stuff that should end up in the GAME layer. |
Gotcha, figured as much - just didn't want to wait and then find I have something else to resolve on top. |
I'm having the same issue. In my case it's a mod I need to add. However the suggested solution does not work for me. I added
The entire run configuration runs {
configureEach {
workingDirectory project.file('run')
systemProperty 'forge.logging.console.level', 'debug'
modSource project.sourceSets.main
modSource project(":CreativeCore").sourceSets.main
}
client {
}
} Am I doing something wrong? Also tried to use |
Make sure that you set the same mod identifier on all the source sets. |
Not sure what exactly you mean. |
All your source sets should have runs {
modIdentifier = name
} Might be best to ask on discord in the #modder-support-gradle channel. |
I'm currently working on migrating my mods over to the latest NeoForge versions and am running into some issues with NeoGradle 7 that I wasn't having on older versions.
My current setup uses two projects, one of which is the game library that I distribute - Compound, and the other is the test mod used to validate the functions of the library - Molecule.
The way I have the project organized is a child project for Compound, and a parent project for Molecule that adds the Compound project as a dependency. I had this working previously using compileOnly and by specifying the source set for my mod to include the child project. You can see this configuration here: https://github.com/tridentmc/molecule/tree/1.20
I've tried to adjust this to match the changes that were made to NeoGradle, including using the runtime dependency system introduced in a recent PR - unfortunately this hasn't really given me much success. You can see my current setup here: https://github.com/tridentmc/molecule/tree/1.20.2
As of right now I get errors related to task dependencies: https://gist.github.com/darkevilmac/c8b349ac16092282e72a418c004b2831
I attempted to put a fix in place for this based on the error log
However this just results in an error related to missing NeoForge classes when running.
I'm somewhat at a loss here at this point, this feels like it might be a regression or I could just be missing something obvious.
Relevant ForgeGradle issues: MinecraftForge/ForgeGradle#583 MinecraftForge/ForgeGradle#557
Any help at all would be appreciated
The text was updated successfully, but these errors were encountered: