Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime dynamic dependency can fail to evict existing dependency #97

Closed
Mumfrey opened this issue Jan 4, 2024 · 2 comments
Closed

Runtime dynamic dependency can fail to evict existing dependency #97

Mumfrey opened this issue Jan 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Mumfrey
Copy link

Mumfrey commented Jan 4, 2024

Pull Request #52 added support for dynamic runtime dependencies, however it seems that under certain circumstances the original dependency is not evicted in favour of the new dependency:

Per the "direct" usage in #52, I would expect the following to result in the newer dependency ending up in the runtime classpath:

dependencies {
    implementation 'org.spongepowered:mixin:0.8.6-SNAPSHOT'
}

runs {
    client {
        dependencies {
            runtime 'org.spongepowered:mixin:0.8.6-SNAPSHOT'
        }
    }
}

However the original dependency is still added to the runtime classpath.

@shartte
Copy link
Contributor

shartte commented Jan 4, 2024

After some debugging, it relates to gradle/gradle#6881

@Matyrobbrt Matyrobbrt added the bug Something isn't working label Jan 5, 2024
@marchermans
Copy link
Contributor

Fixed in the latest release, we switched to name dependencies fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants