some style changes and fixes #34

UltimatChamp · 2024-05-10T06:45:30Z

Full-sized website window for a modern look.
Added transitions to everything.
A new look for badges.
- Also, added a new Legacy badge.
Provided a Hugo executable file like gradlew (fixes Fails to build with Hugo 0.125.3 #33).
Fixed the single-lined code block on notices to look unreadable in light mode.
Covered some more IDEs in .gitignore.
Fixes "Latest News" contains all news items instead of just the latest few ones #36
Check newer comments for more.

Preview URL: https://pr-34.neoforged-website-previews.pages.dev

- Full-sized website window for a modern look. - Added transitions to everything. - Added a new Legacy badge. - Provided a Hugo executable file like `gradlew` (fixes neoforged#33). - Fixed the single-lined code block on notices to look unreadable in light mode. - Covered some more IDEs in `.gitignore`.

neoforged-pages-deployments · 2024-05-10T06:47:17Z

Deploying with Cloudflare Pages

Name	Result
Last commit:	a165d5d0182a6e8b42434293189d1c14540e1098
Status:	✅ Deploy successful!
Preview URL:	https://8558016f.neoforged-website-previews.pages.dev
PR Preview URL:	https://pr-34.neoforged-website-previews.pages.dev

hugo.exe

themes/mainroad/assets/css/style.css

sciwhiz12

After consulting with others, it seems the old screen, limited in width it may be, looks better on wide screens rather than the changes in this PR.

While there is a lot of wasted space on the existing layout, it's much more readable as the text is in a confined column, rather than stretching across the screen without balancing text size and other factors.

In line with that, please revert back to the fixed-width layout. We can discuss changing to a full-width layout in another PR, hopefully in a way that looks readable on wide screens.

UltimatChamp · 2024-05-16T14:23:02Z

Hmm... I'll revert the changes you asked in a bit. It'll be nice if someone could make a better fullscreen solution; the current one is just pretty bugging.

ChampionAsh5357 · 2024-05-16T14:51:12Z

The transition and dimming effect on the version bar makes it look like the option is greyed out while also having the colors meld together, making it look washy. Could we remove the transition to see whether the effect looks better. If it still has a similar issue, I would suggest removing the transition and dimming effect for the bar altogether and just leaving the border around the version bar to indicate selection.

Non-hovered:

Hovered:

UltimatChamp · 2024-05-16T15:39:26Z

Ok!

Also, I'll record some visual representations of the changes you and Sci have asked for better comparison. (and btw the highlight and the versions dropdowns were made pr-ed by me; just reading project-talk on discord lol)

the transition effect is already not on neoforged.net

UltimatChamp · 2024-05-17T06:27:00Z

I've fixed the latest hugo crash, by disabling the google analytics feature, since I don't think it's used anywhere.
- if it's important, from what i've found, google_analytics.html is it's replacement (from google_analytics_async.html; this is what the website was using; it's now removed from hugo)
"Latest News" contains all news items instead of just the latest few ones #36 has been fixed by renaming ~~Latest~~ News to News. (This requested function is already performed by the Recent Posts widget by showing the latest 5 news)
I've reverted back the fullscreen change.
Hovering on the installer, the dropdown title will no longer be dimmed.
The hovering feature is now only on the badges and the new version block on the dropwdown title.
I've fixed the odd-looking toggle button, when it changes from a square to a circle. It's now from a squicircle to a circle.
The Latest NeoForge Installer version text has been changed to monospace.
The notice code block color has been dimmed as requested.

UltimatChamp · 2024-05-17T06:57:35Z

Should I do this?

rec_neo2.mp4

sciwhiz12 · 2024-05-17T11:33:50Z

Should I do this?
rec_neo2.mp4

I think that's too distracting, personally.

sciwhiz12

Thanks for figuring out the Hugo issue! We'll look into updating to the latest Hugo version on Cloudflare and here after this PR is merged.

The change in font size of the badges and code block in the version dropdowns are a bit too distracting, I think. At most, we could have them dim on hover, but changing size is a bit much. (And no other code block should really be dimming on hover, I think, to avoid association with e.g., buttons.)

sciwhiz12 · 2024-05-17T11:35:53Z

themes/mainroad/assets/css/style.css

@@ -239,6 +248,11 @@ code {
 	padding: 0 5px;
 }

+code:hover {
+	filter: brightness(.85);
+	cursor: pointer;


Why? It's a bit distracting to hover over a code block in a page and see it change to the hand pointer (for links and buttons), when it is not a button or a link. (It might also give the impression that you can click to copy?)

Also, is dimming the code block necessary? I think it should just be treated as ordinary text.

you can click to copy?

we can do that, actually.

OK, no more experimenting. I'll finalise the pr shortly.

UltimatChamp · 2024-05-17T12:13:20Z

what about now?

sciwhiz12

Looks good to me, just a small nitpick.

sciwhiz12 · 2024-05-17T12:16:12Z

themes/mainroad/assets/css/style.css

@@ -1076,13 +1071,11 @@ details[open] summary {
 }

 summary code:hover {
-	font-size: 15px;
+        filter: brightness(.85);


I think you accidentally'd the indentation. 😄

sciwhiz12

Thanks!

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 10, 2024 06:46 Active

Merge branch 'main' into main

4d98021

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 16, 2024 12:36 Active

sciwhiz12 requested changes May 16, 2024

View reviewed changes

hugo.exe Outdated Show resolved Hide resolved

themes/mainroad/assets/css/style.css Outdated Show resolved Hide resolved

themes/mainroad/assets/css/style.css Show resolved Hide resolved

themes/mainroad/assets/css/style.css Outdated Show resolved Hide resolved

sciwhiz12 force-pushed the main branch from 7349327 to ea73744 Compare May 16, 2024 12:54

sciwhiz12 requested changes May 16, 2024

View reviewed changes

some fixes and requested changes

933ed59

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 06:20 Active

UltimatChamp requested a review from sciwhiz12 May 17, 2024 06:20

Merge branch 'neoforged:main' into main

573cf01

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 07:05 Active

icons for the new links + hover effects for badges

1cdc289

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 07:17 Active

sciwhiz12 requested changes May 17, 2024

View reviewed changes

more changes

01ee50a

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 12:05 Active

sciwhiz12 added enhancement New feature or request bug Something isn't working labels May 17, 2024

undo the font transition change

2601021

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 12:10 Active

UltimatChamp requested a review from sciwhiz12 May 17, 2024 12:12

sciwhiz12 requested changes May 17, 2024

View reviewed changes

fix indentation

a165d5d

UltimatChamp requested a review from sciwhiz12 May 17, 2024 12:34

neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) May 17, 2024 12:35 Active

sciwhiz12 approved these changes May 17, 2024

View reviewed changes

sciwhiz12 merged commit e37612f into neoforged:main May 17, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

some style changes and fixes #34

some style changes and fixes #34

UltimatChamp commented May 10, 2024 •

edited

neoforged-pages-deployments bot commented May 10, 2024 •

edited

sciwhiz12 left a comment

UltimatChamp commented May 16, 2024

ChampionAsh5357 commented May 16, 2024

UltimatChamp commented May 16, 2024 •

edited

UltimatChamp commented May 17, 2024 •

edited

UltimatChamp commented May 17, 2024

sciwhiz12 commented May 17, 2024

sciwhiz12 left a comment

sciwhiz12 May 17, 2024

UltimatChamp May 17, 2024

UltimatChamp commented May 17, 2024

sciwhiz12 left a comment

sciwhiz12 May 17, 2024

sciwhiz12 left a comment

some style changes and fixes #34

some style changes and fixes #34

Conversation

UltimatChamp commented May 10, 2024 • edited

neoforged-pages-deployments bot commented May 10, 2024 • edited

Deploying with Cloudflare Pages

sciwhiz12 left a comment

Choose a reason for hiding this comment

UltimatChamp commented May 16, 2024

ChampionAsh5357 commented May 16, 2024

UltimatChamp commented May 16, 2024 • edited

UltimatChamp commented May 17, 2024 • edited

UltimatChamp commented May 17, 2024

sciwhiz12 commented May 17, 2024

sciwhiz12 left a comment

Choose a reason for hiding this comment

sciwhiz12 May 17, 2024

Choose a reason for hiding this comment

UltimatChamp May 17, 2024

Choose a reason for hiding this comment

UltimatChamp commented May 17, 2024

sciwhiz12 left a comment

Choose a reason for hiding this comment

sciwhiz12 May 17, 2024

Choose a reason for hiding this comment

sciwhiz12 left a comment

Choose a reason for hiding this comment

UltimatChamp commented May 10, 2024 •

edited

neoforged-pages-deployments bot commented May 10, 2024 •

edited

UltimatChamp commented May 16, 2024 •

edited

UltimatChamp commented May 17, 2024 •

edited