Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor support for vscode #107

Open
Victorious3 opened this issue Apr 22, 2019 · 7 comments
Open

Editor support for vscode #107

Victorious3 opened this issue Apr 22, 2019 · 7 comments
Assignees

Comments

@Victorious3
Copy link
Collaborator

Victorious3 commented Apr 22, 2019

I thought I should post this here since the repo contains grammars for other editors, and it could be useful to someone.

I've written a vscode addon a while ago to support syntax highlighting and eventually autocompletion for symbols: https://github.com/Victorious3/vscode-TatSu

It is quite involved, but sadly unfinished since I discovered a glaring issue in vscode that makes writing it a complete pain.

Waiting for this PR: microsoft/vscode-languageserver-node#367
And this: microsoft/vscode#580

Apart from that, writing typescript is only marginally less annoying than writing Javascript so my motivation to enhance it is limited.

Screenshot (43)

It's not on the Marketplace yet since its performance characteristics are a bit... questionable (due to the issue mentioned above, it parses the entire file on every edit) and its lacking support for goto symbol.

@apalala
Copy link
Collaborator

apalala commented Apr 22, 2019

Please add a pull request for this @Victorious3, so it gets included in the next release. It's the best way to gather help for finishing the work.

@Victorious3
Copy link
Collaborator Author

Victorious3 commented Apr 22, 2019

@apalala Aight, I can do that. Would you publish the addon when its done? I'm thinking having a separate repo for this as well as the other editor support might be useful.

I think I can also include my updated tmlanguage file since it contains some improvements over this one.

@apalala
Copy link
Collaborator

apalala commented Apr 22, 2019

We'd publish it right-away, with a caveat.

@Victorious3
Copy link
Collaborator Author

I'm not sure how to include this into the project structure...
I would use a seperate repo, with a submodule perhaps?
Feel free to pull it from my repo and integrate it as you see fit.

@apalala
Copy link
Collaborator

apalala commented Apr 22, 2019

Oh! It's not a single program file, but a complete VS project. We should mention it in the documentation, then.

@FezVrasta
Copy link

@Victorious3 does your proof of concept include a working language parser?

I'm trying to generate an abstract syntax tree from a TatSu EBNF on the client-side (JavaScript).

@Victorious3
Copy link
Collaborator Author

@FezVrasta No, I'm using the textmate grammar, its not a complete parser, only enough to provide syntax highlighting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
release-plan
  
To Do
Development

No branches or pull requests

3 participants