Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal.view.learn.PageContainer: Footer Button on first page #5350

Open
tobiu opened this issue Mar 17, 2024 · 4 comments
Open

Portal.view.learn.PageContainer: Footer Button on first page #5350

tobiu opened this issue Mar 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tobiu
Copy link
Collaborator

tobiu commented Mar 17, 2024

Assuming this one should not take the full width, but the last 50%.

Screenshot 2024-03-17 at 14 21 53
@tobiu tobiu added the enhancement New feature or request label Mar 17, 2024
@tobiu tobiu added this to To do in Portal & LearningSection via automation Mar 17, 2024
@Michael-Nwachukwu
Copy link

hey @tobiu, can i work on this?

@tobiu
Copy link
Collaborator Author

tobiu commented Mar 18, 2024

hi @Michael-Nwachukwu!

it depends on how @mxmrtns wants the footer to look like.

the JS code is here: https://github.com/neomjs/neo/blob/dev/apps/portal/view/learn/PageContainer.mjs

the logic is data-driven: in case there is no previousPageRecord, the last page button will get the hidden config set to true, which then won't render it into the DOM at all.

the related SCSS is here: https://github.com/neomjs/neo/blob/dev/resources/scss/src/apps/portal/learn/MainContainer.scss#L20

a button has flex: 1 which is fine in case there are 2 buttons, but not so much in case there is just one.

the chicken and egg problem: the ticket is related to the new learning section, which you will need to actually understand how the framework works and more importantly how to use it as a developer. we need around 4 more weeks to publish the new portal app.

you could create a fork, run npm i, then npm run build-all, then ideally enable the theme watcher: npm run watch-themes to get your SCSS compiled into CSS when doing changes. afterwards npm run server-start and open the portal app inside the browser.

my recommendation would be: join the slack channel first. @maxrahder is moderating weekly workshops and can help interested devs in getting up to speed.

@Michael-Nwachukwu
Copy link

Hi @tobiu can i get a link to the slack channel? I just took a look and i indeed need to understand the framework first.

@tobiu
Copy link
Collaborator Author

tobiu commented Mar 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants