Global Variables

[flatcap]

NeoMutt has quite a lot of global variables.
That's not good.

Once you've filtered out the const "variables" (the fixed data), there are 233 195 left.
By comparison, upstream Mutt has 430 non-const globals.

NeoMutt's can be divided into 96 shared and 137 99 static globals.

If you can find a way to eliminate any of them, please let us know.

Thanks ❤️

---

Click to expand the lists:

Shared globals

alias/alias.c:62:                           Aliases                                       struct AliasList Aliases = TAILQ_HEAD_INITIALIZER(Aliases);
autocrypt/config.c:37:                      AutocryptSignAs                               char *AutocryptSignAs = NULL;
autocrypt/config.c:38:                      AutocryptDefaultKey                           char *AutocryptDefaultKey = NULL;
autocrypt/db.c:56:                          AutocryptDB                                   sqlite3 *AutocryptDB = NULL;
browser/dlg_browser.c:140:                  LastDir                                       struct Buffer LastDir = { 0 };
browser/dlg_browser.c:142:                  LastDirBackup                                 struct Buffer LastDirBackup = { 0 };
color/curses.c:38:                          CursesColors                                  struct CursesColorList CursesColors;
color/curses.c:39:                          NumCursesColors                               int NumCursesColors;
color/merged.c:39:                          MergedColors                                  struct AttrColorList MergedColors;
color/notify.c:35:                          ColorsNotify                                  struct Notify *ColorsNotify = NULL;
color/quoted.c:43:                          QuotedColors                                  struct AttrColor QuotedColors[COLOR_QUOTES_MAX];
color/quoted.c:44:                          NumQuotedColors                               int NumQuotedColors;
color/regex.c:48:                           AttachList                                    struct RegexColorList AttachList;
color/regex.c:49:                           BodyList                                      struct RegexColorList BodyList;
color/regex.c:50:                           HeaderList                                    struct RegexColorList HeaderList;
color/regex.c:51:                           IndexAuthorList                               struct RegexColorList IndexAuthorList;
color/regex.c:52:                           IndexCollapsedList                            struct RegexColorList IndexCollapsedList;
color/regex.c:53:                           IndexDateList                                 struct RegexColorList IndexDateList;
color/regex.c:54:                           IndexFlagsList                                struct RegexColorList IndexFlagsList;
color/regex.c:55:                           IndexLabelList                                struct RegexColorList IndexLabelList;
color/regex.c:56:                           IndexList                                     struct RegexColorList IndexList;
color/regex.c:57:                           IndexNumberList                               struct RegexColorList IndexNumberList;
color/regex.c:58:                           IndexSizeList                                 struct RegexColorList IndexSizeList;
color/regex.c:59:                           IndexSubjectList                              struct RegexColorList IndexSubjectList;
color/regex.c:60:                           IndexTagList                                  struct RegexColorList IndexTagList;
color/regex.c:61:                           IndexTagsList                                 struct RegexColorList IndexTagsList;
color/regex.c:62:                           StatusList                                    struct RegexColorList StatusList;
color/simple.c:42:                          SimpleColors                                  struct AttrColor SimpleColors[MT_COLOR_MAX];
core/neomutt.c:38:                          NeoMutt                                       struct NeoMutt *NeoMutt = NULL;
email/globals.c:36:                         AutoSubscribeCache                            struct HashTable *AutoSubscribeCache = NULL;
email/globals.c:38:                         Ignore                                        struct ListHead Ignore = STAILQ_HEAD_INITIALIZER(Ignore);
email/globals.c:40:                         MailLists                                     struct RegexList MailLists = STAILQ_HEAD_INITIALIZER(MailLists);
email/globals.c:42:                         MailToAllow                                   struct ListHead MailToAllow = STAILQ_HEAD_INITIALIZER(MailToAllow);
email/globals.c:44:                         NoSpamList                                    struct RegexList NoSpamList = STAILQ_HEAD_INITIALIZER(NoSpamList);
email/globals.c:46:                         SpamList                                      struct ReplaceList SpamList = STAILQ_HEAD_INITIALIZER(SpamList);
email/globals.c:48:                         SubscribedLists                               struct RegexList SubscribedLists = STAILQ_HEAD_INITIALIZER(SubscribedLists);
email/globals.c:50:                         UnIgnore                                      struct ListHead UnIgnore = STAILQ_HEAD_INITIALIZER(UnIgnore);
email/globals.c:52:                         UnMailLists                                   struct RegexList UnMailLists = STAILQ_HEAD_INITIALIZER(UnMailLists);
email/globals.c:54:                         UnSubscribedLists                             struct RegexList UnSubscribedLists = STAILQ_HEAD_INITIALIZER(UnSubscribedLists);
email/tags.c:41:                            TagTransforms                                 struct HashTable *TagTransforms = NULL;
email/tags.c:42:                            TagFormats                                    struct HashTable *TagFormats = NULL;
globals.c:35:                               ErrorBufMessage                               bool ErrorBufMessage;
globals.c:36:                               ErrorBuf                                      char ErrorBuf[1024];
globals.c:38:                               HomeDir                                       char *HomeDir = NULL;
globals.c:39:                               ShortHostname                                 char *ShortHostname = NULL;
globals.c:41:                               Username                                      char *Username = NULL;
globals.c:43:                               CurrentFolder                                 char *CurrentFolder = NULL;
globals.c:44:                               LastFolder                                    char *LastFolder = NULL;
globals.c:48:                               AlternativeOrderList                          struct ListHead AlternativeOrderList = STAILQ_HEAD_INITIALIZER(AlternativeOrderList);
globals.c:49:                               AutoViewList                                  struct ListHead AutoViewList = STAILQ_HEAD_INITIALIZER(AutoViewList);
globals.c:50:                               HeaderOrderList                               struct ListHead HeaderOrderList = STAILQ_HEAD_INITIALIZER(HeaderOrderList);
globals.c:51:                               MimeLookupList                                struct ListHead MimeLookupList = STAILQ_HEAD_INITIALIZER(MimeLookupList);
globals.c:52:                               Muttrc                                        struct ListHead Muttrc = STAILQ_HEAD_INITIALIZER(Muttrc);
globals.c:53:                               TempAttachmentsList                           struct ListHead TempAttachmentsList = STAILQ_HEAD_INITIALIZER(TempAttachmentsList);
globals.c:54:                               UserHeader                                    struct ListHead UserHeader = STAILQ_HEAD_INITIALIZER(UserHeader);
globals.c:57:                               CurrentMenu                                   enum MenuType CurrentMenu;
globals.c:62:                               OptAutocryptGpgme                             bool OptAutocryptGpgme;
globals.c:64:                               OptDontHandlePgpKeys                          bool OptDontHandlePgpKeys;
globals.c:65:                               OptForceRefresh                               bool OptForceRefresh;
globals.c:66:                               OptKeepQuiet                                  bool OptKeepQuiet;
globals.c:67:                               OptMsgErr                                     bool OptMsgErr;
globals.c:68:                               OptNeedRescore                                bool OptNeedRescore;
globals.c:69:                               OptNeedResort                                 bool OptNeedResort;
globals.c:70:                               OptNews                                       bool OptNews;
globals.c:71:                               OptNewsSend                                   bool OptNewsSend;
globals.c:72:                               OptNoCurses                                   bool OptNoCurses;
globals.c:73:                               OptPgpCheckTrust                              bool OptPgpCheckTrust;
globals.c:74:                               OptResortInit                                 bool OptResortInit;
globals.c:75:                               OptSortSubthreads                             bool OptSortSubthreads;
globals.c:78:                               EnvList                                       char **EnvList = NULL;
gui/dialog.c:80:                            AllDialogsWindow                              struct MuttWindow *AllDialogsWindow = NULL;
gui/msgcont.c:40:                           MessageContainer                              struct MuttWindow *MessageContainer = NULL;
gui/rootwin.c:106:                          RootWindow                                    struct MuttWindow *RootWindow = NULL;
gui/terminal.c:42:                          TsSupported                                   bool TsSupported;
imap/msg_set.c:50:                          ImapMaxCmdlen                                 int ImapMaxCmdlen = 8192;
key/get.c:48:                               MacroEvents                                   struct KeyEventArray MacroEvents = ARRAY_HEAD_INITIALIZER;
key/lib.c:63:                               KeyNames                                      struct Mapping KeyNames[] = {
key/lib.c:125:                              AbortKey                                      keycode_t AbortKey;
key/lib.c:128:                              Keymaps                                       struct KeymapList Keymaps[MENU_MAX];
main.c:191:                                 StartupComplete                               bool StartupComplete = false;
menu/menu.c:43:                             SearchBuffers                                 char *SearchBuffers[MENU_MAX];
monitor.c:52:                               MonitorFilesChanged                           bool MonitorFilesChanged = false;
monitor.c:54:                               MonitorCurMboxChanged                         bool MonitorCurMboxChanged = false;
mutt/charset.c:61:                          ReplacementChar                               wchar_t ReplacementChar = '?';
mutt/charset.c:66:                          CharsetIsUtf8                                 bool CharsetIsUtf8 = false;
mutt/logging.c:53:                          MuttLogger                                    log_dispatcher_t MuttLogger = log_disp_terminal;
mutt/mbyte.c:44:                            OptLocales                                    bool OptLocales;
mutt/signal.c:63:                           SigInt                                        volatile sig_atomic_t SigInt;
mutt/signal.c:64:                           SigWinch                                      volatile sig_atomic_t SigWinch;
ncrypt/gpgme_functions.c:55:                KeyInfoPadding                                int KeyInfoPadding[KIP_MAX] = { 0 };
nntp/nntp.c:77:                             CurrentNewsSrv                                struct NntpAccountData *CurrentNewsSrv = NULL;
pager/dlg_pager.c:68:                       BrailleRow                                    int BrailleRow = -1;
pager/dlg_pager.c:70:                       BrailleCol                                    int BrailleCol = -1;
pattern/pattern.c:65:                       RangeRegexes                                  struct RangeRegex RangeRegexes[] = {
postpone/postpone.c:58:                     PostCount                                     short PostCount = 0;
sidebar/sidebar.c:43:                       SidebarPinned                                 struct ListHead SidebarPinned = STAILQ_HEAD_INITIALIZER(SidebarPinned);

Static globals

address/group.c:44:                         Groups                                        static struct HashTable *Groups = NULL;
alias/reverse.c:37:                         ReverseAliases                                static struct HashTable *ReverseAliases = NULL;
alternates.c:42:                            Alternates                                    static struct RegexList Alternates = STAILQ_HEAD_INITIALIZER(Alternates);
alternates.c:43:                            UnAlternates                                  static struct RegexList UnAlternates = STAILQ_HEAD_INITIALIZER(UnAlternates);
alternates.c:44:                            AlternatesNotify                              static struct Notify *AlternatesNotify = NULL;
attach/attachments.c:56:                    AttachAllow                                   static struct ListHead AttachAllow = STAILQ_HEAD_INITIALIZER(AttachAllow);
attach/attachments.c:57:                    AttachExclude                                 static struct ListHead AttachExclude = STAILQ_HEAD_INITIALIZER(AttachExclude);
attach/attachments.c:58:                    InlineAllow                                   static struct ListHead InlineAllow = STAILQ_HEAD_INITIALIZER(InlineAllow);
attach/attachments.c:59:                    InlineExclude                                 static struct ListHead InlineExclude = STAILQ_HEAD_INITIALIZER(InlineExclude);
attach/attachments.c:60:                    AttachmentsNotify                             static struct Notify *AttachmentsNotify = NULL;
autocrypt/db.c:45:                          AccountGetStmt                                static sqlite3_stmt *AccountGetStmt = NULL;
autocrypt/db.c:46:                          AccountInsertStmt                             static sqlite3_stmt *AccountInsertStmt = NULL;
autocrypt/db.c:47:                          AccountUpdateStmt                             static sqlite3_stmt *AccountUpdateStmt = NULL;
autocrypt/db.c:48:                          AccountDeleteStmt                             static sqlite3_stmt *AccountDeleteStmt = NULL;
autocrypt/db.c:49:                          PeerGetStmt                                   static sqlite3_stmt *PeerGetStmt = NULL;
autocrypt/db.c:50:                          PeerInsertStmt                                static sqlite3_stmt *PeerInsertStmt = NULL;
autocrypt/db.c:51:                          PeerUpdateStmt                                static sqlite3_stmt *PeerUpdateStmt = NULL;
autocrypt/db.c:52:                          PeerHistoryInsertStmt                         static sqlite3_stmt *PeerHistoryInsertStmt = NULL;
autocrypt/db.c:53:                          GossipHistoryInsertStmt                       static sqlite3_stmt *GossipHistoryInsertStmt = NULL;
color/parse_color.c:59:                     AttributeNames                                static struct Mapping AttributeNames[] = {
commands.c:76:                              MuttrcStack                                   static struct ListHead MuttrcStack = STAILQ_HEAD_INITIALIZER(MuttrcStack);
conn/gnutls.c:75:                           ProtocolPriority                              static int ProtocolPriority[] = { GNUTLS_TLS1_2, GNUTLS_TLS1_1, GNUTLS_TLS1, GNUTLS_SSL3, 0 };
conn/gsasl.c:39:                            MuttGsaslCtx                                  static Gsasl *MuttGsaslCtx = NULL;
conn/openssl.c:85:                          HostExDataIndex                               static int HostExDataIndex = -1;
conn/openssl.c:89:                          SkipModeExDataIndex                           static int SkipModeExDataIndex = -1;
conn/sasl.c:126:                            MuttSaslCallbacks                             static sasl_callback_t MuttSaslCallbacks[5];
conn/sasl.c:129:                            SecretPtr                                     static sasl_secret_t *SecretPtr = NULL;
core/command.c:35:                          Commands                                      static struct CommandArray Commands = ARRAY_HEAD_INITIALIZER;
core/config_cache.c:39:                     CacheActive                                   static bool CacheActive = false;
core/mailbox.c:291:                         GC                                            static struct EmailGarbageCollector GC = { 0 };
envelope/window.c:88:                       HeaderPadding                                 static int HeaderPadding[HDR_ATTACH_TITLE] = { 0 };
envelope/window.c:90:                       MaxHeaderWidth                                static int MaxHeaderWidth = 0;
external.c:76:                              LastSaveFolder                                static struct Buffer LastSaveFolder = { 0 };
hcache/hcache.c:62:                         HcacheVer                                     static unsigned int HcacheVer = 0x0;
history/history.c:101:                      Histories                                     static struct History Histories[HC_MAX];
history/history.c:104:                      OldSize                                       static int OldSize = 0;
hook.c:80:                                  Hooks                                         static struct HookList Hooks = TAILQ_HEAD_INITIALIZER(Hooks);
hook.c:83:                                  IdxFmtHooks                                   static struct HashTable *IdxFmtHooks = NULL;
hook.c:86:                                  CurrentHookType                               static HookFlags CurrentHookType = MUTT_HOOK_NO_FLAGS;
key/get.c:52:                               UngetKeyEvents                                static struct KeyEventArray UngetKeyEvents = ARRAY_HEAD_INITIALIZER;
monitor.c:57:                               INotifyFd                                     static int INotifyFd = -1;
monitor.c:59:                               Monitor                                       static struct Monitor *Monitor = NULL;
monitor.c:61:                               PollFdsCount                                  static size_t PollFdsCount = 0;
monitor.c:63:                               PollFdsLen                                    static size_t PollFdsLen = 0;
monitor.c:65:                               PollFds                                       static struct pollfd *PollFds = NULL;
monitor.c:67:                               MonitorCurMboxDescriptor                      static int MonitorCurMboxDescriptor = -1;
mutt/charset.c:83:                          Lookups                                       static struct LookupList Lookups = TAILQ_HEAD_INITIALIZER(Lookups);
mutt/charset.c:98:                          IconvCache                                    static struct IconvCacheEntry IconvCache[ICONV_CACHE_SIZE];
mutt/charset.c:100:                         IconvCacheUsed                                static int IconvCacheUsed = 0;
mutt/logging.c:55:                          LogFileFP                                     static FILE *LogFileFP = NULL;
mutt/logging.c:56:                          LogFileName                                   static char *LogFileName = NULL;
mutt/logging.c:57:                          LogFileLevel                                  static int LogFileLevel = 0;
mutt/logging.c:58:                          LogFileVersion                                static char *LogFileVersion = NULL;
mutt/logging.c:63:                          LogQueue                                      static struct LogLineList LogQueue = STAILQ_HEAD_INITIALIZER(LogQueue);
mutt/logging.c:65:                          LogQueueCount                                 static int LogQueueCount = 0;
mutt/logging.c:66:                          LogQueueMax                                   static int LogQueueMax = 0;
mutt/pool.c:37:                             BufferPoolCount                               static size_t BufferPoolCount = 0;
mutt/pool.c:39:                             BufferPoolLen                                 static size_t BufferPoolLen = 0;
mutt/pool.c:45:                             BufferPool                                    static struct Buffer **BufferPool = NULL;
mutt/qsort_r.c:38:                          GlobalCompar                                  static sort_t GlobalCompar = NULL;
mutt/qsort_r.c:40:                          GlobalData                                    static void *GlobalData = NULL;
mutt/random.c:45:                           FpRandom                                      static FILE *FpRandom = NULL;
mutt/signal.c:39:                           Sigset                                        static sigset_t Sigset;
mutt/signal.c:41:                           SigsetSys                                     static sigset_t SigsetSys;
mutt/signal.c:44:                           SysOldInt                                     static struct sigaction SysOldInt;
mutt/signal.c:46:                           SysOldQuit                                    static struct sigaction SysOldQuit;
mutt/signal.c:50:                           SignalsBlocked                                static bool SignalsBlocked;
mutt/signal.c:54:                           SysSignalsBlocked                             static bool SysSignalsBlocked;
mutt/signal.c:57:                           SigHandler                                    static sig_handler_t SigHandler = mutt_sig_empty_handler;
mutt/signal.c:59:                           ExitHandler                                   static sig_handler_t ExitHandler = mutt_sig_exit_handler;
mutt/signal.c:61:                           SegvHandler                                   static sig_handler_t SegvHandler = mutt_sig_exit_handler;
mutt_logging.c:47:                          LastError                                     static uint64_t LastError = 0;
mutt_logging.c:49:                          CurrentFile                                   static char *CurrentFile = NULL;
mutt_lua.c:57:                              LuaState                                      static lua_State *LuaState = NULL;
mutt_mailbox.c:43:                          MailboxTime                                   static time_t MailboxTime = 0;
mutt_mailbox.c:44:                          MailboxStatsTime                              static time_t MailboxStatsTime = 0;
mutt_mailbox.c:45:                          MailboxCount                                  static short MailboxCount = 0;
mutt_mailbox.c:46:                          MailboxNotify                                 static short MailboxNotify = 0;
mutt_signal.c:45:                           IsEndwin                                      static int IsEndwin = 0;
ncrypt/crypt_gpgme.c:92:                    IdDefaults                                    static struct CryptCache *IdDefaults = NULL;
ncrypt/crypt_gpgme.c:94:                    SignatureKey                                  static gpgme_key_t SignatureKey = NULL;
ncrypt/crypt_gpgme.c:96:                    CurrentSender                                 static char *CurrentSender = NULL;
ncrypt/crypt_mod.c:48:                      CryptModules                                  static struct CryptModuleList CryptModules = STAILQ_HEAD_INITIALIZER(CryptModules);
ncrypt/gnupgparse.c:75:                     Charset                                       static char *Charset = NULL;
ncrypt/pgp.c:69:                            PgpPass                                       static char PgpPass[1024];
ncrypt/pgp.c:71:                            PgpExptime                                    static time_t PgpExptime = 0;
ncrypt/pgpkey.c:73:                         IdDefaults                                    static struct PgpCache *IdDefaults = NULL;
ncrypt/pgppacket.c:38:                      PacketBuf                                     static unsigned char *PacketBuf = NULL;
ncrypt/pgppacket.c:39:                      PacketBufLen                                  static size_t PacketBufLen = 0;
ncrypt/smime.c:70:                          SmimePass                                     static char SmimePass[256];
ncrypt/smime.c:72:                          SmimeExpTime                                  static time_t SmimeExpTime = 0;
ncrypt/smime.c:75:                          SmimeKeyToUse                                 static struct Buffer SmimeKeyToUse = { 0 };
ncrypt/smime.c:77:                          SmimeCertToUse                                static struct Buffer SmimeCertToUse = { 0 };
ncrypt/smime.c:79:                          SmimeIntermediateToUse                        static struct Buffer SmimeIntermediateToUse = { 0 };
postpone/postpone.c:60:                     UpdateNumPostponed                            static bool UpdateNumPostponed = false;
score.c:61:                                 ScoreList                                     static struct Score *ScoreList = NULL;
send/sendmail.c:64:                         SigAlrm                                       static volatile sig_atomic_t SigAlrm;
subjectrx.c:40:                             SubjectRegexList                              static struct ReplaceList SubjectRegexList = STAILQ_HEAD_INITIALIZER(SubjectRegexList);
subjectrx.c:41:                             SubjRxNotify                                  static struct Notify *SubjRxNotify = NULL;

[flatcap]

Update: I've eliminated 38 Config definitions, e.g. IndexVar from the "Static globals".
They're mostly const, but we secretly store the config value in them.

Config globals

alias/config.c:97:                          AliasVars                                     static struct ConfigDef AliasVars[] = {
autocrypt/config.c:64:                      AutocryptVars                                 static struct ConfigDef AutocryptVars[] = {
browser/config.c:135:                       BrowserVars                                   static struct ConfigDef BrowserVars[] = {
compose/config.c:64:                        ComposeVars                                   static struct ConfigDef ComposeVars[] = {
conn/config.c:39:                           ConnVars                                      static struct ConfigDef ConnVars[] = {
conn/config.c:66:                           ConnVarsSsl                                   static struct ConfigDef ConnVarsSsl[] = {
conn/config.c:113:                          ConnVarsGnutls                                static struct ConfigDef ConnVarsGnutls[] = {
conn/config.c:130:                          ConnVarsOpenssl                               static struct ConfigDef ConnVarsOpenssl[] = {
conn/config.c:151:                          ConnVarsPartial                               static struct ConfigDef ConnVarsPartial[] = {
conn/config.c:165:                          ConnVarsGetaddr                               static struct ConfigDef ConnVarsGetaddr[] = {
hcache/config.c:126:                        HcacheVars                                    static struct ConfigDef HcacheVars[] = {
hcache/config.c:142:                        HcacheVarsComp                                static struct ConfigDef HcacheVarsComp[] = {
hcache/config.c:160:                        HcacheVarsComp2                               static struct ConfigDef HcacheVarsComp2[] = {
hcache/config.c:172:                        HcacheVarsPage                                static struct ConfigDef HcacheVarsPage[] = {
helpbar/config.c:37:                        HelpbarVars                                   static struct ConfigDef HelpbarVars[] = {
history/config.c:56:                        HistoryVars                                   static struct ConfigDef HistoryVars[] = {
imap/config.c:71:                           ImapVars                                      static struct ConfigDef ImapVars[] = {
imap/config.c:147:                          ImapVarsZlib                                  static struct ConfigDef ImapVarsZlib[] = {
index/config.c:37:                          IndexVars                                     static struct ConfigDef IndexVars[] = {
maildir/config.c:70:                        MaildirVars                                   static struct ConfigDef MaildirVars[] = {
maildir/config.c:92:                        MaildirVarsHcache                             static struct ConfigDef MaildirVarsHcache[] = {
mbox/config.c:37:                           MboxVars                                      static struct ConfigDef MboxVars[] = {
menu/config.c:37:                           MenuVars                                      static struct ConfigDef MenuVars[] = {
mh/config.c:37:                             MhVars                                        static struct ConfigDef MhVars[] = {
mutt_config.c:405:                          MainVars                                      static struct ConfigDef MainVars[] = {
mutt_config.c:941:                          MainVarsMixmaster                             static struct ConfigDef MainVarsMixmaster[] = {
mutt_config.c:958:                          MainVarsIdn                                   static struct ConfigDef MainVarsIdn[] = {
ncrypt/config.c:109:                        NcryptVars                                    static struct ConfigDef NcryptVars[] = {
ncrypt/config.c:214:                        NcryptVarsGpgme                               static struct ConfigDef NcryptVarsGpgme[] = {
ncrypt/config.c:293:                        NcryptVarsPgp                                 static struct ConfigDef NcryptVarsPgp[] = {
ncrypt/config.c:363:                        NcryptVarsSmime                               static struct ConfigDef NcryptVarsSmime[] = {
nntp/config.c:59:                           NntpVars                                      static struct ConfigDef NntpVars[] = {
notmuch/config.c:106:                       NotmuchVars                                   static struct ConfigDef NotmuchVars[] = {
pager/config.c:43:                          PagerVars                                     static struct ConfigDef PagerVars[] = {
pattern/config.c:57:                        PatternVars                                   static struct ConfigDef PatternVars[] = {
pop/config.c:71:                            PopVars                                       static struct ConfigDef PopVars[] = {
send/config.c:137:                          SendVars                                      static struct ConfigDef SendVars[] = {
sidebar/config.c:91:                        SidebarVars                                   static struct ConfigDef SidebarVars[] = {
</details>

[klartext]

Replace global Variables by non-global Variables

The following steps might be used for the whole program,
or for parts of it (modules/compilation units).

So if there are global variables that are used in many places of the program
already, the steps should be applied for the whole program.

If some global variables are only used inside one C-file / compilation unit (and
it makes sense to let it be this way), and also should not be accessed from
elsewhere, apply the steps for these variables for that compilation unit only.

That there already is a globals.c I had not in mind, when writing these rather generic text.
Things might be adapted somewhat. But as far as I can see, not all globals are in globals.c, and some dangle around elsewhere (which might be ok or not and up for discussion).

I: Awareness

1. Identify the global variables

2. Make the global variables obvious in the code: introduce extern-declarations at start of functions.

3. Make the global variables even more obvious by renaming them, for example so that they start with global_ or g_.

II: Refactorings

4. Group definition of globals together into a global structure.
   For example global_buffer_foo and global_counter_bar would then be accessed by
   globals->buffer_foo abd globals->counter_bar

   Group initialization of the globals together (if possible) into one function.
   Otherwise group then together into functions related to certain modules/tasks.

5. Start replacing global variables, by adding them as function parameters in function definitions
   and function calls.

6. Remove the globals from the global struct, where step 5 has been completed.
   If for some reason it makes sense to let the variable be global and in the structure,
   let it be there.
   But at this point usage of these variables all should be done via function parameters.

III: Ideas on how to achieve these Steps

Some existing tools might be used, which can help.
Or some custom scripts might help also.
Now follow some ideas, what tools might be used,
without the claim that this is the ideal tool.
Just some suggestions or discussion-hints.

For step 1:

• coccinelle
• directly analysing object files (nm + grep?)
• custom scripts (some grep, some perl etc.)

For step 2:

• coccinelle to add the declarations
• custom scripts (some grep, some perl etc.)

For step 3:

• coccinelle
• editor
• custom scripts (some grep, some perl etc.)

For step 4:

• cocinelle
• editor

For step 5:

• coccinelle
• editor
• custom scripts (some grep, some perl etc.)

For step 6:

• editor

[klartext]

Regarding the use of nm, here a simple script for playing around:

for obj in *.o; do echo -e "\n$obj:\n-----------" ; nm $obj |grep '[0-9A-Fa-f]* [BCDGRS]' |cut -d ' ' -f 3 | grep -v ^$ ; done

This is inspired by this discussion here:
https://bytes.com/topic/c/answers/852490-finding-global-variables

I just started with some of the first recommendations there, there is more that can be used to get more precise output.