Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qwant for the search engine #317

Open
Tracked by #313
neon-mmd opened this issue Oct 13, 2023 · 11 comments
Open
Tracked by #313

Qwant for the search engine #317

neon-mmd opened this issue Oct 13, 2023 · 11 comments

Comments

@neon-mmd
Copy link
Owner

neon-mmd commented Oct 13, 2023

Provide the qwant search engine for the websurfx search engine. To start working on this issue, you will need to create a new file with the name of the desired engine in the folder src/engines/ which is located under the codebase (websurfx directory). Then in the file, just create a new struct with the name of the engine and then create two impl blocks for the struct. One for implementing the SearchEngine trait on it and the other for implementing the parsers to be used for aggregating results.

After that, just put the name of the desired engine in the match statement located here, make sure that the name of engine is in lowercase.

After that, just move to the config file which is located at websurfx/ directory under the code base and then just edit the config file by including the name of the search engine here.

Note
The engine name to be included in the config file is not case sensitive but we would still recommend naming it with the camelcase naming convention.

After doing all the fore-mentioned steps, then we would suggest doing a thorough test to make sure everything works as intended and then submitting a PR.

@github-actions
Copy link

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md

@neon-mmd neon-mmd added this to the Complete v2.0.0 release milestone Oct 13, 2023
@neon-mmd neon-mmd changed the title Qwant for the search engine Qwant for the search engine Oct 13, 2023
@diogocanut
Copy link
Contributor

Hey, I want to take this one if not taken : )

@neon-mmd
Copy link
Owner Author

neon-mmd commented Dec 13, 2023

Hey, I want to take this one if not taken : )

Yes sure, we will assign this issue to you right away 🚀 🙂 .

@neon-mmd
Copy link
Owner Author

neon-mmd commented Dec 20, 2023

Diogocanut, it has been nearly a month, any progress on this issue so far? We would like to know 🙂 .

@jfvillablanca
Copy link
Contributor

if this isn't being worked on, i'd like to take this one.

@diogocanut
Copy link
Contributor

@jfvillablanca you can take it, had no time to finish yet

@neon-mmd
Copy link
Owner Author

neon-mmd commented Jan 2, 2024

@jfvillablanca you can take it, had no time to finish yet

Ok thanks ❤️ diogocanut for keeping us updated. Since do not you want to work on this issue therefore we will re-assign the issue to jfvillablanca. Hope to see you soon with another issue in the project. 🙂

@neon-mmd neon-mmd assigned jfvillablanca and unassigned diogocanut Jan 2, 2024
@neon-mmd
Copy link
Owner Author

neon-mmd commented Jan 2, 2024

Jfvillablanca, we have now assigned this issue to you. You may start working ln it right away 🚀 🙂 .

@jfvillablanca
Copy link
Contributor

Feel free to unassign this issue from me. I can't commit some time to work on this currently.

@neon-mmd
Copy link
Owner Author

neon-mmd commented Feb 3, 2024

Feel free to unassign this issue from me. I can't commit some time to work on this currently.

Yes sure, no problem. We will un-assign you from this issue right away 🚀. Also, thanks ❤️ for keeping us update on this issue. 🙂

Copy link

github-actions bot commented Apr 4, 2024

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
@neon-mmd neon-mmd reopened this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment