test or feat: timeline hash via fullbackup #7715
Labels
a/test
Area: related to testing
c/storage/pageserver
Component: storage: pageserver
t/feature
Issue type: feature, for new features or requests
Comments
koivunej
added
t/feature
One could argue that it's not easy to hashdos us by using the relation numbers, so these could all be FxHasher based collections. I am unsure if that would give us the determinism in all possible cases. |
|
Would also like to use this for things like |
|
For sharding I think the pythonic way will work better, as you can merge the lists of hashes (which will still be unique), as I assume one needs to do with sharding. |
koivunej
added a commit
that referenced
this issue
May 22, 2024
"taking a fullbackup" is an ugly multi-liner copypasted in multiple places, most recently with timeline ancestor detach tests. move it under `PgBin` which is not a great place, but better than yet another utility function. Additionally: - cleanup `psql_env` repetition (PgBin already configures that) - move the backup tar comparison as a yet another free utility function - use backup tar comparison in `test_import.py` where a size check was done previously - cleanup extra timeline creation from test Cc: #7715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least in tests it would be nice to have a hash for timeline state at lsn.
This is computed in
test_ancestor_detach_branched_fromand it should be used intest_import.pyas well. Path to stable hashable full backup:zenith.signalMore context: #7706 (comment)
Alternatively the fullbackup and tar_cmp should be refactored and re-used in
test_import.pywhich currently only compares the tar sizes, probably because portable fullbackup comparison seemed too time consuming to implement at the time.The text was updated successfully, but these errors were encountered: