-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature (content): Using Shiki Transformers #1690
Comments
Being addressed in #1724. |
@rishi-raj-jain JS implementation looks good and according the shiki transformers docs 👏 Regarding CSS I'd like to:
|
@rishi-raj-jain I also noticed that we need to update our copy button with styles and functionality in case of transformers. Styles But has a lack of background for light theme Functionality If you want me, I can help you with this, uploading my commit |
Appreciate your detailed review. Yes, it'd be great to have help from you! |
Would you be open to committing the changes as you suggested earlier as well? I'm happy to as well. |
@rishi-raj-jain ok sure, I'll commit my updates now. Copy button would take extra time by the way, but I'll work on this too. |
Thank you, @saimonkat! |
@rishi-raj-jain updated styles for highlighting and fix for copy button in #1724. There is only one bug left, removed line of code provides empty line in result of copying: Hope you could help me to take a look at this commit 8b55b94 |
Taking a look now! |
Added a fix, please review @saimonkat. |
@rishi-raj-jain Thanks! I'm not home now, but overall looks like a good fix overall by the code 🔥 I'll review closer when I'm back home |
Hey @rishi-raj-jain your fix looks really good and works good as well, thank you! I just optimized it a little bit and I think we're ready! |
@saimonkat Thank you! I've simplified it even further: 92f6c2e. Feel free to drop an approving review for it. |
Currently, Shiki is integrated into the system (which is awesome), but highlighting a particular line as insertion and deletion with specific colors is missing. It's a good to have.
The text was updated successfully, but these errors were encountered: