Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out blueprint detection from tags. vs. main branch #605

Open
liamfallon opened this issue Apr 8, 2024 · 3 comments
Open

Figure out blueprint detection from tags. vs. main branch #605

liamfallon opened this issue Apr 8, 2024 · 3 comments
Labels
area/platform area/porch Porch related issues enhancement New feature or request triaged

Comments

@liamfallon
Copy link
Member

Original issue URL: kptdev/kpt#3269
Original issue user: https://github.com/mortent
Original issue created at: 2022-05-27T21:52:25Z
Original issue last updated at: 2022-05-27T21:52:25Z
Original issue body: Should we:

  • hide packages in main? (well, but they are there)
  • not merge them into main at all? (this will likely not match customer expectation of branching/tagging in Git)
  • or de-dupe identical packages? (in this case packages will pop up 'out of nowhere' when a duplicate blueprint is deleted but some of the dupes still remain)

We have already added functionality that tags the latest revision (kptdev/kpt#3015).

Original issue comments:

@tliron tliron transferred this issue from nephio-project/porch-issue-transfer Apr 23, 2024
@liamfallon
Copy link
Member Author

This is to do with a PackageRevision being created for main.

Blueprints:
When you approve, Porch commits the package to main and creates a tag. So there are two PackageRevision instances created, one for the tag and another for main.

We need to rethink how this works because this automatically created PackageRevision is confusing for users.

The discovery function should not rely on the main PackageRevision.

Deployment:

This PackageRevision is also used for deployment. The main PacakgeRevision may have been created for deployment.

@henderiw
Copy link
Contributor

Here is the code related to this issue.

https://github.com/nephio-project/porch/blob/1754fc8fd09f799471d0916c50921b0b27aef50d/pkg/git/git.go#L262

@liamfallon
Copy link
Member Author

Triaged
Triage Comment: Part of Porch rearchitecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform area/porch Porch related issues enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

2 participants