Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porch: additional concurrency tests #608

Open
liamfallon opened this issue Apr 8, 2024 · 0 comments
Open

porch: additional concurrency tests #608

liamfallon opened this issue Apr 8, 2024 · 0 comments
Labels
area/platform area/porch Porch related issues area/test-infra SIG Release Test Infra enhancement New feature or request triaged

Comments

@liamfallon
Copy link
Member

Original issue URL: kptdev/kpt#4003
Original issue user: https://github.com/johnbelamaric
Original issue created at: 2023-07-08T00:19:18Z
Original issue last updated at: 2023-07-21T16:03:24Z
Original issue body: ### Describe your problem

In #3993 we added checks for resource version. This should help a lot, but it's probably not sufficient. For example, I suspect since we don't acquire a pacakgerevision mutex, you could still have a race condition where two simultaneous update calls came in and bypassed each others resource version checks. Similarly, I am not sure whether we have mutex on the package revision / package revision resources when we do our multi-commit saves (maybe we do have this?).

In any case, I suspect there is still a fair bit of work to do to make sure all concurrency issues are resolved, so I am raising this issue to track that work.

Original issue comments:
Comment user: https://github.com/johnbelamaric
Comment created at: 2023-07-08T00:21:59Z
Comment last updated at: 2023-07-08T00:21:59Z
Comment body: See also: kptdev/kpt#3993 (comment)

@tliron tliron transferred this issue from nephio-project/porch-issue-transfer Apr 23, 2024
@liamfallon liamfallon added triaged area/test-infra SIG Release Test Infra labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform area/porch Porch related issues area/test-infra SIG Release Test Infra enhancement New feature or request triaged
Projects
Status: No status
Development

No branches or pull requests

2 participants