Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.22 #510

Closed
tliron opened this issue Feb 10, 2024 · 3 comments · Fixed by nephio-project/porch#41, #597 or nephio-project/test-infra#258
Closed

Upgrade to Go 1.22 #510

tliron opened this issue Feb 10, 2024 · 3 comments · Fixed by nephio-project/porch#41, #597 or nephio-project/test-infra#258
Assignees
@tliron @liamfallon
Labels
area/platform sig/automation
Milestone
R3

Comments

@tliron
Copy link

tliron commented Feb 10, 2024

Things to do (please add more!):

  • Update Makef and Docker files to use/require go 1.22.0 for builds.
  • Change all go.mod files with the go 1.22 directive.
  • We often use reflect.TypeOf(), but in most cases we should change to the new reflect.TypeFor[] generic function.
@tliron tliron added this to the R3 milestone Feb 10, 2024
@tliron tliron self-assigned this Feb 10, 2024
This was referenced Apr 23, 2024
Merged
Merged
Merged
@liamfallon
Copy link
Member

There are a few PRs to go through before this issue can be closed.

@liamfallon liamfallon reopened this Apr 23, 2024
@liamfallon
Copy link
Member

/assign @liamfallon

@liamfallon
Copy link
Member

The PR for the Nephio repo is not merged yet.

@liamfallon liamfallon reopened this May 14, 2024
nephio-prow bot pushed a commit that referenced this issue May 14, 2024
@liamfallon
Upgrade Nephio to Go 1.22 (#597)
c165a09 
**What type of PR is this?**

> Uncomment only one /kind <> line, hit enter to put that in a new line,
and remove leading whitespaces from that line:
>  /kind bug

/kind cleanup

> /kind design
> /kind documentation
> /kind failing-test
> /kind feature
> /kind flake

**What this PR does / why we need it:**

- Updated go version in go.mod files
- Updated go version in github workflows
- Updated base image to 1.22.2-bookworm in Dockerfiles
- Updated Go/Golang-CI/GoSec versions in makefiles
- Updated reflect.TypeOf() to reflect.TypeFor[]() where relevant

**Which issue(s) this PR fixes:**
Fixes [Issue 510](#510).

**Special notes for your reviewer:**

**Does this PR introduce a user-facing change?:**
no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tliron tliron

@liamfallon liamfallon

Labels
area/platform sig/automation
Projects
R3
Status: Done
Milestone
R3
3 participants
@tliron @gvbalaji @liamfallon