Skip to content

Commit

Permalink
test: use test lib for mocks in ssr tests so they run on node 16
Browse files Browse the repository at this point in the history
  • Loading branch information
nerdyman committed Sep 1, 2023
1 parent 2100c6f commit 495dc7a
Show file tree
Hide file tree
Showing 6 changed files with 602 additions and 482 deletions.
4 changes: 2 additions & 2 deletions docs/example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"devDependencies": {
"@types/react": "^18.2.21",
"@types/react-dom": "^18.2.7",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"@typescript-eslint/eslint-plugin": "^6.5.0",
"@typescript-eslint/parser": "^6.5.0",
"@vitejs/plugin-react": "^4.0.3",
"eslint": "^8.45.0",
"eslint-plugin-react-hooks": "^4.6.0",
Expand Down
4 changes: 2 additions & 2 deletions docs/ssr-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
},
"devDependencies": {
"@types/node": "^20.5.7",
"jest-mock": "^29.6.3",
"react": "^18.2.0",
"react-compare-slider": "latest",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"test": "^3.3.0"
}
}
12 changes: 6 additions & 6 deletions docs/ssr-tests/ssr.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,19 @@
const assert = await import('node:assert');
const { describe, it } = await import('node:test');

// Using `jest-mock` instead of built-in Node.js `mock` to allow this to run on node 16.
const mock = await import('jest-mock');
const { createElement, isValidElement } = await import('react');
const { renderToStaticMarkup } = await import('react-dom/server');
// Using npm version of node built-in test lib to allow the test suite to run on node 16.
const { MockTracker } = await import('test/lib/internal/test_runner/mock.js');

const { ReactCompareSlider, ReactCompareSliderHandle, ReactCompareSliderImage, styleFitContainer } =
await import('react-compare-slider');

describe('SSR', () => {
it('should render without error', () => {
const mockConsoleError = mock.spyOn(console, 'error');
const mockConsoleWarn = mock.spyOn(console, 'warn');
const mock = new MockTracker();
const mockConsoleError = mock.method(console, 'error');
const mockConsoleWarn = mock.method(console, 'warn');

const root = createElement(ReactCompareSlider, {
handle: createElement(ReactCompareSliderHandle, {}),
Expand All @@ -38,7 +39,6 @@ describe('SSR', () => {
assert.strictEqual(mockConsoleError.mock.calls.length, 0);
assert.strictEqual(mockConsoleWarn.mock.calls.length, 0);

mockConsoleError.mockRestore();
mockConsoleWarn.mockRestore();
mock.reset();
});
});
24 changes: 12 additions & 12 deletions docs/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,22 @@
"devDependencies": {
"@storybook/addon-console": "^2.0.0",
"@storybook/addon-coverage": "^0.0.9",
"@storybook/addon-docs": "^7.3.2",
"@storybook/addon-essentials": "^7.3.2",
"@storybook/addon-interactions": "^7.3.2",
"@storybook/addon-links": "^7.3.2",
"@storybook/addon-storysource": "^7.3.2",
"@storybook/blocks": "^7.3.2",
"@storybook/builder-vite": "^7.3.2",
"@storybook/jest": "^0.2.1",
"@storybook/addon-docs": "^7.4.0",
"@storybook/addon-essentials": "^7.4.0",
"@storybook/addon-interactions": "^7.4.0",
"@storybook/addon-links": "^7.4.0",
"@storybook/addon-storysource": "^7.4.0",
"@storybook/blocks": "^7.4.0",
"@storybook/builder-vite": "^7.4.0",
"@storybook/jest": "^0.2.2",
"@storybook/preset-typescript": "^3.0.0",
"@storybook/react": "^7.3.2",
"@storybook/react-vite": "^7.3.2",
"@storybook/react": "^7.4.0",
"@storybook/react-vite": "^7.4.0",
"@storybook/test-runner": "^0.13.0",
"@storybook/testing-library": "^0.2.0",
"@storybook/theming": "^7.3.2",
"@storybook/theming": "^7.4.0",
"remark-gfm": "^3.0.1",
"storybook": "^7.3.2",
"storybook": "^7.4.0",
"typescript": "^5.2.2",
"vite": "^4.4.9"
}
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,14 @@
"react-dom": ">=16.8"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.8.0",
"@arethetypeswrong/cli": "^0.9.0",
"@ianvs/prettier-plugin-sort-imports": "^3.7.2",
"@types/node": "^20.5.7",
"@types/react": "^18.2.21",
"@types/react-dom": "^18.2.7",
"@types/resize-observer-browser": "^0.1.7",
"@typescript-eslint/eslint-plugin": "^6.4.1",
"@typescript-eslint/parser": "^6.4.1",
"@typescript-eslint/eslint-plugin": "^6.5.0",
"@typescript-eslint/parser": "^6.5.0",
"browserslist": "^4.21.10",
"c8": "^8.0.1",
"concurrently": "^8.2.1",
Expand Down

0 comments on commit 495dc7a

Please sign in to comment.