Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle goes out of container when switching from landscape to portrait when position is 100 #106

Closed
Tracked by #94
nerdyman opened this issue Jan 18, 2023 · 1 comment
Closed
Tracked by #94

Handle goes out of container when switching from landscape to portrait when position is 100 #106

nerdyman opened this issue Jan 18, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
v3

Comments

@nerdyman
Copy link
Owner

nerdyman commented Jan 18, 2023 •
edited

Repro:

https://react-compare-slider.vercel.app/?path=/story/demos--images

  1. Set position to 100
  2. Enable portrait

Result: Slider goes outside of container and cannot be seen.
@nerdyman nerdyman added the bug Something isn't working label Jan 18, 2023
@nerdyman nerdyman added this to the v3 milestone Jan 18, 2023
@nerdyman nerdyman mentioned this issue Jan 30, 2023
Merged
21 tasks
@nerdyman
Copy link
Owner Author

Resolved in v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
react-compare-slider-v3
Status: Done
Milestone
v3
Development

No branches or pull requests
1 participant
@nerdyman