-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace touch and mouse events with pointer events #74
Comments
hey @nerdyman I would like to work on this. But could you describe a more like |
Hey @muditchoudhary! I've updated the ticket to include a link to a reference implementation and have added some requirements. I still need to do #87 before any Hacktoberfest tickets can be merged, I'll be sorting it out later today. |
okay, No issue. |
This is ready to tackle @muditchoudhary , let me know if you need any more info. |
okay, that's awesome, I'll start working today If I need any help I'll surely reach you. |
Hello, @nerdyman I'm getting this error when I replace MouseEvent | TouchEvent with PointerEvent : But If I Put it like this |
One more thing, where will I find the |
@muditchoudhary Those events need removed/replaced with Here's a link to the diff for the pointer events in that PR. The styles for the root element are in The linked PR should have everything needed to check the requirements for this PR. This isn't the simplest issue so if you'd like something else for Hacktoberfest #75 is also open. |
@nerdyman If this issue requires the work of just replacing the events in the code I could do that. I'll try to fix this issue with the help of your PR. If I will not able to do it I'll tell you. |
The library currently uses
mouse
andtouch
event bindings from V1 when IE11 was supported. All currently targeted browsers supportpointer
events so they should be used instead.See 5c84c5c (full file here) for a reference implementation.
Requirements
touchAction: 'none'
style property to root elementmousedown
event binding withpointerdown
touchstart
event bindingMouseEvent | TouchEvent
withPointerEvent
instanceof
ternaries in mouse and touch handlers, we can useev.pageX
andev.pageY
Testing
TODO
The text was updated successfully, but these errors were encountered: