Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using percentage units internally instead of percentage and pixel mix #80

Closed
Tracked by #94
nerdyman opened this issue Oct 5, 2022 · 1 comment · Fixed by #94
Closed
Tracked by #94

Try using percentage units internally instead of percentage and pixel mix #80

nerdyman opened this issue Oct 5, 2022 · 1 comment · Fixed by #94
Labels
enhancement New feature or request
Milestone
v3

Comments

@nerdyman
Copy link
Owner

nerdyman commented Oct 5, 2022 •
edited

Since we're now using clip-path we can use % units instead of pixels.

This may remove the need for the ResizeObverser in the main component as the percentage value will still be the same even when the component resizes. It should also should hopefully resolve the Safari keyboard increment issue from #69 and the Safari console error from #103.

^ The above is probably not possible because boundsPadding is pixel based, so it needs to be recalcuated on resize relative to the root container.

Considerations:

  • boundsPadding and CSS scaling should still be respected
@nerdyman nerdyman added this to the v3 milestone Oct 5, 2022
@nerdyman nerdyman added the enhancement New feature or request label Oct 5, 2022
@nerdyman nerdyman mentioned this issue Oct 5, 2022
Closed
@nerdyman nerdyman self-assigned this Oct 18, 2022
@nerdyman nerdyman changed the title Try using percentage units everywhere instead of percentage and pixel mix Try using percentage units internally instead of percentage and pixel mix Nov 10, 2022
@nerdyman nerdyman mentioned this issue Nov 12, 2022
Merged
21 tasks
@nerdyman nerdyman linked a pull request Nov 12, 2022 that will close this issue
v3 #94
Merged
21 tasks
nerdyman added a commit that referenced this issue Jan 6, 2023
@nerdyman
refactor: use clip-path and percentages internally, #80
953da7d
nerdyman added a commit that referenced this issue Jan 30, 2023
@nerdyman
fix: prevent slider handle from exiting container when switching to p…
267ff68 
…ortrait when `position` is `100` closes #80 #94
@nerdyman
Copy link
Owner Author

Resolved in v3.

@nerdyman nerdyman removed their assignment Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
react-compare-slider-v3
Status: Done
Milestone
v3
Development

Successfully merging a pull request may close this issue.

v3 nerdyman/react-compare-slider
1 participant
@nerdyman