Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only publish ESM version and update build target #81

Closed
6 tasks done
Tracked by #94
nerdyman opened this issue Oct 5, 2022 · 1 comment · Fixed by #94
Closed
6 tasks done
Tracked by #94

Only publish ESM version and update build target #81

nerdyman opened this issue Oct 5, 2022 · 1 comment · Fixed by #94
Assignees
@nerdyman
Labels
build
Milestone
v3

Comments

@nerdyman
Copy link
Owner

nerdyman commented Oct 5, 2022 •
edited

CJS isn't needed anymore. We only need to publish a standard minified ESM version of the library with sourcemaps.

  • Update package.json to use module fields & verify type resolution works
  • Set build target to browserslist versions
  • Use esbuild-plugin-browserslist
  • Add pkg-ok to ensure build is valid
  • Use arethetypeswrong to verify type resolution is working
  • Verify everything works on node 16+
@nerdyman nerdyman added this to the v3 milestone Oct 5, 2022
@nerdyman nerdyman added the build label Oct 5, 2022
@nerdyman nerdyman self-assigned this Nov 12, 2022
@nerdyman nerdyman mentioned this issue Nov 12, 2022
Merged
21 tasks
@nerdyman nerdyman linked a pull request Nov 12, 2022 that will close this issue
v3 #94
Merged
21 tasks
nerdyman added a commit that referenced this issue Apr 7, 2023
@nerdyman
build(deps): add pkg-ok to validate package configuration #81
e0ff502
@nerdyman nerdyman changed the title Only publish .mjs version and update build target Only publish ESM version and update build target May 5, 2023
@nerdyman
Copy link
Owner Author

Closed by #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nerdyman nerdyman

Labels
build
Projects
No open projects
react-compare-slider-v3
Status: Done
Milestone
v3
Development

Successfully merging a pull request may close this issue.

v3 nerdyman/react-compare-slider
1 participant
@nerdyman