Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fire movement event on mouse left down #92

Closed
Tracked by #94
nerdyman opened this issue Oct 18, 2022 · 1 comment · Fixed by #94
Closed
Tracked by #94

Only fire movement event on mouse left down #92

nerdyman opened this issue Oct 18, 2022 · 1 comment · Fixed by #94
Labels
enhancement New feature or request
Milestone
v3

Comments

@nerdyman
Copy link
Owner

nerdyman commented Oct 18, 2022 •
edited

Movement is currently triggered on any mouse button, it should only fire on left click to allow right click to work as normal without the slider sticking to the mouse.

Although it's unlikely anyone was relying on it also working on right click, this commit should be marked as a BREAKING CHANGE.
@nerdyman nerdyman added the enhancement New feature or request label Oct 18, 2022
@nerdyman nerdyman added this to the v3 milestone Oct 18, 2022
@nerdyman nerdyman mentioned this issue Nov 12, 2022
Merged
21 tasks
@nerdyman nerdyman linked a pull request Nov 12, 2022 that will close this issue
v3 #94
Merged
21 tasks
nerdyman added a commit that referenced this issue Jan 5, 2023
@nerdyman
BREAKING CHANGE: only fire slider position change on left mouse click…
04f24e3 
… (or standard touch event) closes #92
@nerdyman
Copy link
Owner Author

nerdyman commented Jan 5, 2023

Will land in v3.0.0

@nerdyman nerdyman closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
react-compare-slider-v3
Status: Done
Milestone
v3
Development

Successfully merging a pull request may close this issue.

v3 nerdyman/react-compare-slider
1 participant
@nerdyman