Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy tensor construction #3135

Closed
gtangg12 opened this issue May 10, 2024 · 2 comments
Closed

Legacy tensor construction #3135

gtangg12 opened this issue May 10, 2024 · 2 comments

Comments

@gtangg12
Copy link
Contributor

nerfstudio/nerfstudio/cameras/cameras.py

Line 173 in 7ba02be

fc_xy = torch.Tensor([fc_xy], device=self.device)

Can we change this to torch.tensor() instead, since on some torch versions, this does not allow construction on GPU

https://discuss.pytorch.org/t/cannot-construct-tensor-directly-on-gpu-in-torch-1-10-1/153751/2
@jb-ye
Copy link
Collaborator

jb-ye commented May 14, 2024

Yes! Could you send a PR to change it? It looks like a simple fix.

@gtangg12 gtangg12 mentioned this issue May 14, 2024
Merged
@gtangg12
Copy link
Contributor Author

See #3145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtangg12 @jb-ye