Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: tests for default ttl #199

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

hliang
Copy link
Contributor

@hliang hliang commented Nov 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: tests

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Just additional tests. No change to behavior.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Following up on #194, add tests to validate default ttl is not mutated.
All tests pass:
image

@kamilmysliwiec kamilmysliwiec merged commit d6dc7a3 into nestjs:master Nov 9, 2023
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants