Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema-builder): allow enums for orphanedTypes #1839

Merged

Conversation

greatSumini
Copy link
Contributor

@greatSumini greatSumini commented Oct 30, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Allow adding an enum to a schema output using orphanedTypes
(need docs update)

Issue Number: #1665

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@greatSumini greatSumini changed the title feat(schema-builder): allow enums for orphaned types feat(schema-builder): allow enums for orphanedTypes Oct 30, 2021
@kamilmysliwiec kamilmysliwiec merged commit f2015f5 into nestjs:master Nov 24, 2021
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants