Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets copying from "nest build" is problematic #1117

Closed
ricardovigatti opened this issue Apr 7, 2021 · 5 comments
Closed

assets copying from "nest build" is problematic #1117

ricardovigatti opened this issue Apr 7, 2021 · 5 comments

Comments

@ricardovigatti
Copy link

I'm submitting a...


[ ] Regression 
[x ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Assets aren't copied properly using "compilerOptions" at "nest-cli.json" file. Eg.:


// nest-cli.json
{
  "collection": "@nestjs/schematics",
  "sourceRoot": "src",
  "compilerOptions": {
    "assets": [
      { "include": "../node_modules/admin-lte/dist", "outDir": "public" },
      { "include": "../node_modules/admin-lte/plugins", "exclude": "../node_modules/admin-lte/plugins/filterizr", "outDir": "public" }
    ]
  }
}

After I run "nest start" or "nest build", some files and folders were copied, but a few others are missing. For example, the "bootstrap" folder, exists at "node_modules/admin-lte/plugins/bootstrap" but was not copied.

Expected behavior

All files and folder of "admin-lte/dist" and "admin-lte/plugins" should be copied. With the exception of the "filterizr" directory.

Minimal reproduction of the problem with instructions

  1. nest new project-name
  2. npm install admin-lte --save
  3. Use the "nest-cli.json" file provided above.
  4. Run nest start or nest build

What is the motivation / use case for changing the behavior?

Copying of assets is problematic.

Environment

[System Information]
OS Version     : Windows 10
NodeJS Version : v14.12.0
NPM Version    : 6.14.8 

[Nest CLI]
Nest CLI Version : 7.6.0

[Nest Platform Information]
platform-express version : 7.6.15
common version           : 7.6.15
core version             : 7.6.15
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

@ricardovigatti
Copy link
Author

Sorry, but i have no idea how to fix this.

@NikolaPeevski
Copy link
Contributor

@kamilmysliwiec Pr is up. Could you take a look?

@FredericEspiau
Copy link
Contributor

I just wanted you to know that I have the same issue as well :)

@kamilmysliwiec
Copy link
Member

Let's track this here #1264

kamilmysliwiec added a commit that referenced this issue Oct 18, 2021
fix: assets copying from 'nest build' is problematic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants