Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): custom collection in config #1166

Merged

Conversation

ledniy
Copy link
Contributor

@ledniy ledniy commented May 10, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #954

What is the new behavior?

Following order of collection resolving: command --collection option -> config collection -> fallback

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ledniy ledniy marked this pull request as ready for review May 10, 2021 14:03
@ledniy ledniy changed the title fix: custom collection in config fix(): custom collection in config May 10, 2021
@ledniy
Copy link
Contributor Author

ledniy commented May 20, 2021

@kamilmysliwiec Hi, any chance for review? We really wanna use our custom collection through the nest cli :)

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilmysliwiec kamilmysliwiec merged commit c59c827 into nestjs:master Jul 7, 2021
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants