Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watch mode): toggle webpack development mode on watch #1319

Merged
merged 1 commit into from Sep 27, 2021

Conversation

ajubin
Copy link
Contributor

@ajubin ajubin commented Sep 1, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 1318

#1318

What is the new behavior?

See issue

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ajubin
Copy link
Contributor Author

ajubin commented Sep 1, 2021

Hi, I'm not sure how to test my change directly from the forked code.
I've tried my fix on my node_modules in my project though, but since I did it on dist code, it's not exactly the same

Do I need to do something else for documenting ?

@ajubin
Copy link
Contributor Author

ajubin commented Sep 3, 2021

Hi @kamilmysliwiec , is there any reason not to merge this PR ? I can work on it if something is missing :)

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll wait to hear from Kamil, but the change looks straightforward enough

@kamilmysliwiec
Copy link
Member

LGTM

This will be added in the next release

@kamilmysliwiec kamilmysliwiec merged commit a350000 into nestjs:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants