Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add optional --strict flag on "nest new" #1344

Merged
merged 3 commits into from Sep 29, 2021
Merged

feat(): add optional --strict flag on "nest new" #1344

merged 3 commits into from Sep 29, 2021

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Sep 28, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: nestjs/schematics#597

What is the new behavior?

CLI users can use nest new --strict if they want to turn on TypeScript's strict mode in their projects from beginning, ie. the following TS compiler options will be true instead of the default false: strictNullChecks, noImplicitAny, strictBindCallApply, forceConsistentCasingInFileNames and noFallthroughCasesInSwitch

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I upgraded @nestjs/schematics dependency to 8.0.3 to use the strict option of it.
I changed the semver range in package.json to make this requirement explicit.

Since the `strict` option was released in v8.0.3 of `@nestjs/schematics`,
we must upgraded it before
This addresses the issue nestjs/schematics#597

Now users can use:
$ nest new --strict
if they want to create a project with TS's strict mode enabled
@kamilmysliwiec kamilmysliwiec merged commit 33d0935 into nestjs:master Sep 29, 2021
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants