Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cli-table3 to v0.6.0 #1359

Merged
merged 1 commit into from Oct 18, 2021
Merged

chore(deps): update dependency cli-table3 to v0.6.0 #1359

merged 1 commit into from Oct 18, 2021

Conversation

iloverink
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1358

What is the new behavior?

Clean audit report

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec mentioned this pull request Oct 13, 2021
4 tasks
@jmcdo29
Copy link
Member

jmcdo29 commented Oct 13, 2021

@kamilmysliwiec is there a reason or renovate config wouldn't pick up this update? It seems strange that we'd need a manual PR for this

@jmcdo29
Copy link
Member

jmcdo29 commented Oct 13, 2021

Also, @iloverink, are there any breading changes in the cli-table3 API, or is this purely a package bump for the sake of dependent packages? As it's below "stable" range, we should be sure that the nest CLI is still working after the upgrade

@kamilmysliwiec
Copy link
Member

I think I've manually blocked updated to cli-table in the past as there were some major braking changes but I might be wrong

@iloverink
Copy link
Contributor Author

@jmcdo29 The change log for 0.6.0 does indicate that cli-table3 dropped support for node 6 and 8 as breaking changes. Does nest support those version? Otherwise it looks like cli-table3 just updated some dependencies for the release.

@jmcdo29
Copy link
Member

jmcdo29 commented Oct 13, 2021

Yeah, Nest does not support v6 or v8 of Node, so it sounds like this should be fine. If I have some time today I'll pull down the PR and run some commands against it locally

@kamilmysliwiec
Copy link
Member

@jmcdo29 that would be awesome! Thanks 🙌

@jmcdo29
Copy link
Member

jmcdo29 commented Oct 15, 2021

nest new, nest info, nest g mo foo, nest g --help, and nest start --watch all run and had the expected output. I got an error with start --watch related to source-map-support/register, but I think that's due to how I was running the command and not the changes themself. I'd say this seems good to go.

Screen Shot 2021-10-15 at 1 03 40 PM

Screen Shot 2021-10-15 at 1 02 55 PM

Screen Shot 2021-10-15 at 1 03 08 PM

Screen Shot 2021-10-15 at 1 03 20 PM

@kamilmysliwiec kamilmysliwiec merged commit bcaa0ab into nestjs:master Oct 18, 2021
@kamilmysliwiec
Copy link
Member

Thank you @jmcdo29 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants