Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lib)!: prioritize 'nest-cli.json' file over all the others name patterns #2042

Merged
merged 1 commit into from Apr 24, 2023

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Apr 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

I believe that the most common name for nestjs CLI config file is nest-cli.json. Still, it is the last one being looked up when loading the config file over 3 others patterns.

I can't tell if this is the desired behavior as it is not documented.

What is the new behavior?

The file nest-cli.json is now the first one to be selected among all the others names which are:

  • .nestcli.json
  • nest-cli.json
  • nest.json

Does this PR introduce a breaking change?

[x] Yes
[ ] No

for instance, people might be using a private/local .nest-cli.json (or any other config file) along with nest-cli.json (which is public) in their projects for whatever reason. We don't want to break them.

Since this was never documented(?), we could think that this isn't a breaking change as well tho.

@micalevisk micalevisk changed the title perf(lib): priorize 'nest-cli.json' file over all the others patterns perf(lib)!: priorize 'nest-cli.json' file over all the others patterns Apr 22, 2023
@micalevisk micalevisk changed the title perf(lib)!: priorize 'nest-cli.json' file over all the others patterns perf(lib)!: priorize 'nest-cli.json' file over all the others name patterns Apr 22, 2023
@micalevisk micalevisk changed the title perf(lib)!: priorize 'nest-cli.json' file over all the others name patterns perf(lib)!: prioritize 'nest-cli.json' file over all the others name patterns Apr 23, 2023
@kamilmysliwiec kamilmysliwiec merged commit 360c3ae into nestjs:master Apr 24, 2023
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

@micalevisk micalevisk deleted the patch-1 branch April 24, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants