perf(lib)!: prioritize 'nest-cli.json' file over all the others name patterns #2042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I believe that the most common name for nestjs CLI config file is
nest-cli.json
. Still, it is the last one being looked up when loading the config file over 3 others patterns.I can't tell if this is the desired behavior as it is not documented.
What is the new behavior?
The file
nest-cli.json
is now the first one to be selected among all the others names which are:.nestcli.json
nest-cli.json
nest.json
Does this PR introduce a breaking change?
for instance, people might be using a private/local
.nest-cli.json
(or any other config file) along withnest-cli.json
(which is public) in their projects for whatever reason. We don't want to break them.Since this was never documented(?), we could think that this isn't a breaking change as well tho.