New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling manual restart for ts watchmode #2070
feat: allow disabling manual restart for ts watchmode #2070
Conversation
Here's a Codesandbox example: https://codesandbox.io/p/sandbox/great-paper-96fkjj Notice when setting |
@kamilmysliwiec any opinions for this issue? Also, I'm not sure if this is considered a new feature or a bugfix |
That's a great catch @m4tt72, thank you! Turns out this feature may have broken existing REPL setups which is definitely unexpected. Perhaps we should turn it off by default then? And let it control with a dedicated flag (as implemented in this repository)? I'm also wondering if we should rename this attribute to be |
Thank you @kamilmysliwiec for the reply. Of course, I don't mind changing the variable name, I was following how nodemon did it, I will push a commit to set it to false 🚀 |
Excellent! Could you also create a PR to the docs (preferably this section https://docs.nestjs.com/cli/monorepo#global-compiler-options ?) adding the new configuration attribute? |
@kamilmysliwiec done, documentation for this option is ready nestjs/docs.nestjs.com#2730 |
LGTM |
@m4tt72 could you please update the |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When running the REPL, the server interferes with the REPL especially when running REPL from within a docker container.
This is implemented in Nodemon: https://github.com/remy/nodemon/blob/main/faq.md#nodemon-doesnt-work-with-my-repl
Issue Number: N/A
What is the new behavior?
Allow manual restart to be disabled, this will prevent nest from listening to STDIN and allow REPL to take over.
Does this PR introduce a breaking change?
Other information