Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEARCH HTTP method #10420

Closed
1 task done
Nisgrak opened this issue Oct 19, 2022 · 3 comments
Closed
1 task done

SEARCH HTTP method #10420

Nisgrak opened this issue Oct 19, 2022 · 3 comments
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@Nisgrak
Copy link

Nisgrak commented Oct 19, 2022

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

I want to use the SEARCH HTTP method with NestJS but it doesn't have the @Search() decorator as @get(), @post(), etc

Describe the solution you'd like

Create a @Search() decorator for use in the controllers.

Teachability, documentation, adoption, migration strategy

Same use as the actual HTTP methods decorators.

Express and Fastify already supports it
http://expressjs.com/en/4x/api.html#routing-methods
https://www.fastify.io/docs/latest/Reference/Routes/#routes-options

A PR was sended a long time ago but it doesn't get merged #9465, it doesn't include SEARCH (it is an old WebDav method) but can be as a base to include all the WebDav methods.

What is the motivation / use case for changing the behavior?

Allow to use the SEARCH HTTP method as the other ones, is a "GET with body" without break any standard.

@Nisgrak Nisgrak added needs triage This issue has not been looked into type: enhancement 🐺 labels Oct 19, 2022
@Gustrb
Copy link
Contributor

Gustrb commented Nov 3, 2022

I'd be really interested in working on this issue, but I'm quite new to open sourcing and to this project codebase, could someone help me get through it? 😄

@micalevisk
Copy link
Member

@Gustrb

@kamilmysliwiec
Copy link
Member

Let's track this here #10533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

4 participants