Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nats pingTimer by flag #10783

Closed
1 task done
andreyddk opened this issue Jan 1, 2023 · 6 comments
Closed
1 task done

Disable nats pingTimer by flag #10783

andreyddk opened this issue Jan 1, 2023 · 6 comments
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@andreyddk
Copy link
Contributor

andreyddk commented Jan 1, 2023

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

The debug message of nats server is annoying and its cant be disabled.
DEBUG [Server] NatsStatus: type: "pingTimer", data: "1".

Describe the solution you'd like

My propose it is extends the implementation existed flag debug of MicroserviceOptions for disable pingTimer message.

Teachability, documentation, adoption, migration strategy

Example of usage.

const app = await NestFactory.createMicroservice<MicroserviceOptions>(
    AppModule,
    {
      transport: Transport.NATS,
      options: {
        servers: nats.servers,
        queue: TENANT_SERVICE_QUEUE,
        debug: false // its disable pingTimer message too.
      }
    }
  );

What is the motivation / use case for changing the behavior?

Unnecessary logs in terminal result the problem with collect logs and understand it.

@andreyddk andreyddk added needs triage This issue has not been looked into type: enhancement 🐺 labels Jan 1, 2023
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this?

@andreyddk
Copy link
Contributor Author

Would you like to create a PR for this?

Yea, sure. I will make it soon.

@andreyddk
Copy link
Contributor Author

I guess I don't have permissions for make pull request.

remote: Permission to nestjs/nest.git denied to andreyddk.

ERROR: Permission to nestjs/nest.git denied to andreyddk.
fatal: Could not read from remote repository.

@jmcdo29
Copy link
Member

jmcdo29 commented Jan 3, 2023

You should make a fork and push your code to it. Then make a PR from your fork to this repo. Pretty standard through most Open Source projects

@andreyddk
Copy link
Contributor Author

You should make a fork and push your code to it. Then make a PR from your fork to this repo. Pretty standard through most Open Source projects

Thank you, its done.

@kamilmysliwiec
Copy link
Member

Let's track this here #10798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

3 participants