Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microservices][Kafka] Empty postfixId not working for ClientKafka #11647

Closed
4 of 15 tasks
quaos opened this issue May 22, 2023 · 1 comment
Closed
4 of 15 tasks

[microservices][Kafka] Empty postfixId not working for ClientKafka #11647

quaos opened this issue May 22, 2023 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@quaos
Copy link

quaos commented May 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Referring to #9677

on the Client side of microservices module, providing postfixId options as empty string still results in -client postfix after the client ID and consumer group ID.

I found this related line:
d88b920#diff-dfaf9025d840c609351b76ce88dbb871cd6b9aca0d552185db8a0cccd28324beR100

Minimum reproduction code

https://codesandbox.io/p/sandbox/test-nest-microservices-client-postfixid-ssmgcw?welcome=true

Steps to reproduce

No response

Expected behavior

Should be able to provide the ClientKafka without default postfix of -client in clientId and groupId

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

9.4.1

Packages versions

{
  "dependencies": {
    "@nestjs/common": "^9.4.1",
    "@nestjs/config": "^2.3.2",
    "@nestjs/core": "^9.4.1",
    "@nestjs/microservices": "9.4.1",
    "@nestjs/platform-express": "^9.4.1",
    "kafkajs": "^2.2.4",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",
    "run-script-webpack-plugin": "0.0.11",
    "rxjs": "^7.4.0",
    "webpack": "5.70.0"
  },
  "devDependencies": {
    "@nestjs/cli": "^8.1.3",
    "@nestjs/schematics": "^9.0.0",
    "@nestjs/testing": "^9.0.0",
    "@types/express": "^4.17.13",
    "@types/jest": "^29.0.0",
    "@types/node": "^16.11.1",
    "@types/supertest": "^2.0.11",
    "@typescript-eslint/eslint-plugin": "^4.29.2",
    "@typescript-eslint/parser": "^4.29.2",
    "eslint": "^7.32.0",
    "eslint-config-prettier": "^8.3.0",
    "eslint-plugin-prettier": "^3.4.1",
    "jest": "^29.0.0",
    "prettier": "^2.4.1",
    "source-map-support": "^0.5.20",
    "supertest": "^6.1.6",
    "ts-jest": "^29.0.0",
    "ts-loader": "^9.2.6",
    "ts-node": "^10.3.0",
    "tsconfig-paths": "^3.11.0",
    "typescript": "^4.4.4"
  }
}

Node.js version

v16.17.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@quaos quaos added the needs triage This issue has not been looked into label May 22, 2023
@kamilmysliwiec
Copy link
Member

This is going to change in v10 #10549

@nestjs nestjs locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

2 participants