Middleware is not triggered when pass controller to consumer's forRoutes()

[ianzone]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

this won't trigger the AuthMiddleware

export class AppModule implements NestModule {
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(AuthMiddleware).forRoutes(UsersController);
  }
}

this will trigger the AuthMiddleware

export class AppModule implements NestModule {
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(AuthMiddleware).forRoutes('users');
  }
}

Minimum reproduction code

https://github.com/ianzone/nest-issue

Steps to reproduce

1. pnpm i
2. pnpm run dev
3. go to localhost:3000/users

Expected behavior

AuthMiddleware get triggered and console logs out 'AuthMiddleware invoked...'

Package

• I don't know. Or some 3rd-party package
• @nestjs/common
• @nestjs/core
• @nestjs/microservices
• @nestjs/platform-express
• @nestjs/platform-fastify
• @nestjs/platform-socket.io
• @nestjs/platform-ws
• @nestjs/testing
• @nestjs/websockets
• Other (see below)

Other package

No response

NestJS version

No response

Packages versions

[System Information]
OS Version : Linux 5.15
NodeJS Version : v18.16.0
PNPM Version : 8.6.2

[Nest CLI]
Nest CLI Version : 10.0.2

[Nest Platform Information]
platform-fastify version : 10.0.1
mapped-types version : 0.0.1
schematics version : 10.0.1
testing version : 10.0.1
common version : 10.0.1
core version : 10.0.1
cli version : 10.0.2

Node.js version

v18.16.0

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[micalevisk]

that seems to be a regression introduce by PR #9809 (v10.0.0)

it looks like we can fix that by calling stripEndSlash on route.path here:

nest/packages/core/middleware/builder.ts

Lines 110 to 112 in da27730

	const isOverlapped = (v: { path: string; regex: RegExp }) => {
	return route.path !== v.path && route.path.match(v.regex);
	};

but I'm unsure if this is the right way to address that

[kamilmysliwiec]

Let's track this here #11837