Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 13 is not support because of dep of uuid 8 #4991

Closed
vipcxj opened this issue Jun 29, 2020 · 7 comments
Closed

Node 13 is not support because of dep of uuid 8 #4991

vipcxj opened this issue Jun 29, 2020 · 7 comments
Labels
needs triage This issue has not been looked into

Comments

@vipcxj
Copy link

vipcxj commented Jun 29, 2020

Bug Report

Current behavior

Node 13 is not support because of dep of uuid 8
see this link

Input Code

const your = (code) => here;

Expected behavior

Node 13 is supported or tell peoples it is not supported in the document.

Possible Solution

downgrade uuid to 7 or demonstrate node 13 is not supported because of uuid in document.

Environment


Nest version: 7.1.0

 
For Tooling issues:
- Node version: 13  
- Platform:  

Others:

@vipcxj vipcxj added the needs triage This issue has not been looked into label Jun 29, 2020
@kamilmysliwiec
Copy link
Member

Btw is there any reason you use v13? This version is not even maintained anymore https://nodejs.org/en/about/releases/. You should rather use either v12 (LTS) or v14 (Current)

@vipcxj
Copy link
Author

vipcxj commented Jun 29, 2020

Btw is there any reason you use v13? This version is not even maintained anymore https://nodejs.org/en/about/releases/. You should rather use either v12 (LTS) or v14 (Current)

I did upgrade to v14, but I also meet this issue when I still in v13. I use v13 just because when I install node, it is the latest stable version. I think not every one alway upgrade their node. If they meet this issue, This can leave them at a loss because the error message doesn't point to the Node version problem at all.

@kamilmysliwiec
Copy link
Member

I use v13 just because when I install node, it is the latest stable version.

v13 is neither stable nor the latest

@vipcxj
Copy link
Author

vipcxj commented Jul 1, 2020

I use v13 just because when I install node, it is the latest stable version.

v13 is neither stable nor the latest

It was the latest version when no 14 released, and not everybody often update node

@gperdomor
Copy link
Contributor

According to uuid readme, Node 13 is not supported, so this issue is not related to NestJS... I think should be closed

Complete - Support for RFC4122 version 1, 3, 4, and 5 UUIDs
Cross-platform - Support for ...
CommonJS, ECMAScript Modules and CDN builds
Node 8, 10, 12, 14
Chrome, Safari, Firefox, Edge, IE 11 browsers
Webpack and rollup.js module bundlers
React Native

@vipcxj
Copy link
Author

vipcxj commented Sep 10, 2020

According to uuid readme, Node 13 is not supported, so this issue is not related to NestJS... I think should be closed

Complete - Support for RFC4122 version 1, 3, 4, and 5 UUIDs
Cross-platform - Support for ...
CommonJS, ECMAScript Modules and CDN builds
Node 8, 10, 12, 14
Chrome, Safari, Firefox, Edge, IE 11 browsers
Webpack and rollup.js module bundlers
React Native

UUID said it not support node 13, but this library not said. And we don't know this library depend on uuid if we not see the "package.json".

@kamilmysliwiec
Copy link
Member

Anyway, there's certainly no reason to downgrade uuid library because it doesn't support an unstable and unsupported version of Node (which shouldn't be used either way).

@nestjs nestjs locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

3 participants