Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest CLI doesn't respect existing yarn workspaces #7224

Closed
ShivamArora opened this issue Jun 3, 2021 · 1 comment
Closed

Nest CLI doesn't respect existing yarn workspaces #7224

ShivamArora opened this issue Jun 3, 2021 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@ShivamArora
Copy link

Bug Report

Nest CLI doesn't respect existing yarn workspaces while generating the resources.

Current behavior

When a resource is generated, Nest CLI adds @nestjs/mapped-types as a dependency to package.json and generates a package-lock.json.

Input Code

None

Expected behavior

Nest CLI should respect the existing yarn workspaces and instead of generating a package-lock.json, it should add the changes to yarn.lock at the workspace root.

Possible Solution

I believe Nest CLI performs an install using npm instead of yarn which results in generation of package-lock.json since it previously doesn't exist.
If there's a way to tell the nest cli to use yarn instead of npm using the nest-cli.json or during the creation of the nest project, it might solve the problem.

Environment


Nest version: 7.6.0

 
For Tooling issues:
- Node version: 14.16.0
- Platform:  Mac

Others:

Package Manager: yarn
@ShivamArora ShivamArora added the needs triage This issue has not been looked into label Jun 3, 2021
@kamilmysliwiec
Copy link
Member

We're tracking this here nestjs/nest-cli#1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

2 participants