Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant throw errors to Kafka's eachMessage #9044

Closed
1 task done
ghost opened this issue Jan 27, 2022 · 1 comment
Closed
1 task done

Cant throw errors to Kafka's eachMessage #9044

ghost opened this issue Jan 27, 2022 · 1 comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@ghost
Copy link

ghost commented Jan 27, 2022

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

I want to throw errors from my controllers to Kafka's eachMessage in order to use kafkajs's retries.
Tried using a custom ExceptionFilter to rethrow the error, but found out it lead to an infinite loop of throw-catch inside RpcProxy

Describe the solution you'd like

Change RpcExceptionsHandler implementation to allow in some way to throw errors behind it

Teachability, documentation, adoption, migration strategy

Should be transparent.

What is the motivation / use case for changing the behavior?

I understand the need to catch every exception, but this really hurts kafkajs expected behaviour, kafka worth nothing to us if we cant handle errors and retries.

@ghost ghost added needs triage This issue has not been looked into type: enhancement 🐺 labels Jan 27, 2022
@kamilmysliwiec
Copy link
Member

Let's track this here #9293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

1 participant