From c36d6bac72883f39760db109552972cae6056b91 Mon Sep 17 00:00:00 2001 From: Tao Wei Date: Fri, 16 Sep 2022 09:24:07 +0000 Subject: [PATCH] fix(common): make `ExtraModuleDefinitionOptions` partial in type --- .../interfaces/configurable-module-cls.interface.ts | 6 ++++-- .../interfaces/configurable-module-host.interface.ts | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts b/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts index e01c706bef9..0335bda2cee 100644 --- a/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts +++ b/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts @@ -21,7 +21,9 @@ export type ConfigurableModuleCls< new (): any; } & Record< `${MethodKey}`, - (options: ModuleOptions & ExtraModuleDefinitionOptions) => DynamicModule + ( + options: ModuleOptions & Partial, + ) => DynamicModule > & Record< `${MethodKey}Async`, @@ -30,6 +32,6 @@ export type ConfigurableModuleCls< ModuleOptions, FactoryClassMethodKey > & - ExtraModuleDefinitionOptions, + Partial, ) => DynamicModule >; diff --git a/packages/common/module-utils/interfaces/configurable-module-host.interface.ts b/packages/common/module-utils/interfaces/configurable-module-host.interface.ts index 6a652ecce2f..c20654d73f3 100644 --- a/packages/common/module-utils/interfaces/configurable-module-host.interface.ts +++ b/packages/common/module-utils/interfaces/configurable-module-host.interface.ts @@ -57,7 +57,7 @@ export interface ConfigurableModuleHost< ModuleOptions, FactoryClassMethodKey > & - ExtraModuleDefinitionOptions; + Partial; /** * Can be used to auto-infer the compound "module options" type (options interface + extra module definition options). * Note: this property is not supposed to be used as a value. @@ -73,5 +73,5 @@ export interface ConfigurableModuleHost< * } * ``` */ - OPTIONS_TYPE: ModuleOptions & ExtraModuleDefinitionOptions; + OPTIONS_TYPE: ModuleOptions & Partial; }