Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove dev dependency @types/cron #1374

Merged
merged 2 commits into from Aug 22, 2023

Conversation

sheerlox
Copy link
Contributor

@sheerlox sheerlox commented Aug 8, 2023

Since @renovate-bot force-pushed renovate/cron-2.x (#1355) after #1356 had been merged into it, the changes were lost and did not reach the master branch. This PR reintroduces these changes.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Development dependencies & documentation update

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reproduces PR: #1356

Commands ran (successfully) to test the changes:

$ npm run build
$ npm run test:integration

@Tony133
Copy link
Contributor

Tony133 commented Aug 21, 2023

@sheerlox as soon as you find some time, can you resolve the conflicts of this PR?

@sheerlox
Copy link
Contributor Author

@Tony133 done 😉

@Tony133
Copy link
Contributor

Tony133 commented Aug 21, 2023

thank you very much @sheerlox 😉👍

@Tony133
Copy link
Contributor

Tony133 commented Aug 21, 2023

@kamilmysliwiec as soon as you find some time can you merge this?

@kamilmysliwiec kamilmysliwiec merged commit 52f9a02 into nestjs:master Aug 22, 2023
1 check passed
@kamilmysliwiec
Copy link
Member

LGTM

@sheerlox sheerlox deleted the fix/remove-types-cron branch August 22, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants