Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .env to generated .gitignore file #1004

Closed
1 task done
nolawnchairs opened this issue Apr 22, 2022 · 3 comments
Closed
1 task done

Add .env to generated .gitignore file #1004

nolawnchairs opened this issue Apr 22, 2022 · 3 comments
Labels

Comments

@nolawnchairs
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Not related to a problem.

Describe the solution you'd like

The auto-generated .gitignore file ought to have .env included by default.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

The .env file is a common file in many projects that holds configuration data and secrets that oughtn't be checked into version control.

@kamilmysliwiec kamilmysliwiec transferred this issue from nestjs/nest-cli Apr 22, 2022
@kamilmysliwiec
Copy link
Member

Would you like to create a PR to address this issue?

@micalevisk
Copy link
Member

micalevisk commented Apr 22, 2022

@micalevisk
Copy link
Member

actually, this is already done. See:

# project files
.env

# project files
.env

We just need to wait for the fix commented here: nestjs/nest-cli#1630 (comment) so nest new could generate those .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants