fix: fix formatting when add spacing at the beginning and/end #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
reviewed
Jan 20, 2024
Comment on lines
+12
to
+15
| ?.trim() | ||
| ?.replace(STRING_DECAMELIZE_REGEXP, '$1-$2') | ||
| ?.toLowerCase() | ||
| ?.replace(STRING_DASHERIZE_REGEXP, '-'); |
There was a problem hiding this comment.
are we sure that the str parameter can be nil? 🤔 if yes, please add yet another test to cover this scenario
There was a problem hiding this comment.
are we sure that the
strparameter can be nil? 🤔 if yes, please add yet another test to cover this scenario
So I just checked into the source and I saw that all implements with default value ...but I just added more unit tests
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
I just realized that I didn't have a code covered by unit tests and identified a possible bug
Does this PR introduce a breaking change?
Other information