Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update angular-cli monorepo to v13 (major) #846

Merged
merged 1 commit into from Nov 16, 2021

Conversation

ddhorstman
Copy link
Contributor

@ddhorstman ddhorstman commented Nov 11, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When attempting to use this package with Node lts/gallium (16.x), an "unsupported engine" warning appears with @angular-devkit/core. This warning appears to be due to a version issue with NPM v8. Despite the warning, everything appears to work correctly using that node version.

WhiteSource Renovate's bot attempted to open a PR updating to version 13, but CircleCI is failing at the build stage because that release dropped the jsonParse utility from the module contents. I fixed the issue by using jsonc-parser 's parse utility as recommended in the release notes.

What is the new behavior?

That warning no longer appears.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Issue #847

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 27cefc4 into nestjs:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants